From 9ec1f11101e604bc1ca9de7d26c33c526cc8579d Mon Sep 17 00:00:00 2001 From: Danielle Maywood Date: Mon, 9 Sep 2024 11:39:40 +0000 Subject: [PATCH 1/3] docs: document minimum version required for 'hidden' attribute (cherry picked from commit ef40a58e63ebf4cb1f4799d552c805473aa83b54) --- docs/resources/app.md | 2 +- provider/app.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resources/app.md b/docs/resources/app.md index aea3439c..5df5406b 100644 --- a/docs/resources/app.md +++ b/docs/resources/app.md @@ -63,7 +63,7 @@ resource "coder_app" "vim" { - `display_name` (String) A display name to identify the app. Defaults to the slug. - `external` (Boolean) Specifies whether `url` is opened on the client machine instead of proxied through the workspace. - `healthcheck` (Block Set, Max: 1) HTTP health checking to determine the application readiness. (see [below for nested schema](#nestedblock--healthcheck)) -- `hidden` (Boolean) Determines if the app is visible in the UI. +- `hidden` (Boolean) Determines if the app is visible in the UI (minimum coder version: v2.16). - `icon` (String) A URL to an icon that will display in the dashboard. View built-in icons here: https://github.com/coder/coder/tree/main/site/static/icon. Use a built-in icon with `"${data.coder_workspace.me.access_url}/icon/"`. - `name` (String, **Deprecated**: `name` on apps is deprecated, use `display_name` instead) A display name to identify the app. - `order` (Number) The order determines the position of app in the UI presentation. The lowest order is shown first and apps with equal order are sorted by name (ascending order). diff --git a/provider/app.go b/provider/app.go index dcf6f22a..9cd794c0 100644 --- a/provider/app.go +++ b/provider/app.go @@ -235,7 +235,7 @@ func appResource() *schema.Resource { }, "hidden": { Type: schema.TypeBool, - Description: "Determines if the app is visible in the UI.", + Description: "Determines if the app is visible in the UI (minimum coder version: v2.16).", Default: false, ForceNew: true, Optional: true, From eea5a25d2ee2ce1927f31b7a2ed2ac28d32f9bbc Mon Sep 17 00:00:00 2001 From: Danielle Maywood Date: Mon, 9 Sep 2024 12:47:46 +0100 Subject: [PATCH 2/3] fix: capitalize coder Co-authored-by: Cian Johnston (cherry picked from commit 30b80cb0687aced0bc0e9c4c159aa39aebab60ac) --- provider/app.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provider/app.go b/provider/app.go index 9cd794c0..62e5bf85 100644 --- a/provider/app.go +++ b/provider/app.go @@ -235,7 +235,7 @@ func appResource() *schema.Resource { }, "hidden": { Type: schema.TypeBool, - Description: "Determines if the app is visible in the UI (minimum coder version: v2.16).", + Description: "Determines if the app is visible in the UI (minimum Coder version: v2.16).", Default: false, ForceNew: true, Optional: true, From 2d1cf7f4f7df4417cd927843dca4e2ffb671a387 Mon Sep 17 00:00:00 2001 From: Danielle Maywood Date: Mon, 9 Sep 2024 11:50:56 +0000 Subject: [PATCH 3/3] fix: apply 'make gen' (cherry picked from commit 036aff9f061213c1032ddf6d56de2667635af2b5) --- docs/resources/app.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/resources/app.md b/docs/resources/app.md index 5df5406b..3c87642a 100644 --- a/docs/resources/app.md +++ b/docs/resources/app.md @@ -63,7 +63,7 @@ resource "coder_app" "vim" { - `display_name` (String) A display name to identify the app. Defaults to the slug. - `external` (Boolean) Specifies whether `url` is opened on the client machine instead of proxied through the workspace. - `healthcheck` (Block Set, Max: 1) HTTP health checking to determine the application readiness. (see [below for nested schema](#nestedblock--healthcheck)) -- `hidden` (Boolean) Determines if the app is visible in the UI (minimum coder version: v2.16). +- `hidden` (Boolean) Determines if the app is visible in the UI (minimum Coder version: v2.16). - `icon` (String) A URL to an icon that will display in the dashboard. View built-in icons here: https://github.com/coder/coder/tree/main/site/static/icon. Use a built-in icon with `"${data.coder_workspace.me.access_url}/icon/"`. - `name` (String, **Deprecated**: `name` on apps is deprecated, use `display_name` instead) A display name to identify the app. - `order` (Number) The order determines the position of app in the UI presentation. The lowest order is shown first and apps with equal order are sorted by name (ascending order).