From 06d0457c505bf00ecdb008ab1d9367deadc55cdf Mon Sep 17 00:00:00 2001
From: Muhammad Atif Ali <atif@coder.com>
Date: Fri, 16 Feb 2024 18:18:01 +0300
Subject: [PATCH 1/2] chore: update description for `coder_app` `url`
This clarifies where users may be confused about how to set an external URL, as the current description only talks about internal URL usage.
Closes #186
---
provider/app.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/provider/app.go b/provider/app.go
index bd2eb21e..ed0ac53e 100644
--- a/provider/app.go
+++ b/provider/app.go
@@ -150,7 +150,7 @@ func appResource() *schema.Resource {
},
"url": {
Type: schema.TypeString,
- Description: "A URL to be proxied to from inside the workspace. " +
+ Description: "An external url if \"external=true\" or a URL to be proxied to from inside the workspace. " +
"This should be of the form \"http://localhost:PORT[/SUBPATH]\". " +
"Either \"command\" or \"url\" may be specified, but not both.",
ForceNew: true,
From 0bce5808354fd72ef303e5de326090a7c9322796 Mon Sep 17 00:00:00 2001
From: Muhammad Atif Ali <me@matifali.dev>
Date: Fri, 16 Feb 2024 15:21:42 +0000
Subject: [PATCH 2/2] make gen
---
docs/resources/app.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/resources/app.md b/docs/resources/app.md
index 631eb1ec..56800b76 100644
--- a/docs/resources/app.md
+++ b/docs/resources/app.md
@@ -77,7 +77,7 @@ resource "coder_app" "intellij" {
- `relative_path` (Boolean, Deprecated) Specifies whether the URL will be accessed via a relative path or wildcard. Use if wildcard routing is unavailable. Defaults to true.
- `share` (String) Determines the "level" which the application is shared at. Valid levels are "owner" (default), "authenticated" and "public". Level "owner" disables sharing on the app, so only the workspace owner can access it. Level "authenticated" shares the app with all authenticated users. Level "public" shares it with any user, including unauthenticated users. Permitted application sharing levels can be configured site-wide via a flag on `coder server` (Enterprise only).
- `subdomain` (Boolean) Determines whether the app will be accessed via it's own subdomain or whether it will be accessed via a path on Coder. If wildcards have not been setup by the administrator then apps with "subdomain" set to true will not be accessible. Defaults to false.
-- `url` (String) A URL to be proxied to from inside the workspace. This should be of the form "http://localhost:PORT[/SUBPATH]". Either "command" or "url" may be specified, but not both.
+- `url` (String) An external url if "external=true" or a URL to be proxied to from inside the workspace. This should be of the form "http://localhost:PORT[/SUBPATH]". Either "command" or "url" may be specified, but not both.
### Read-Only