Skip to content

coder_parameter doc has examples with country icons that don't exist #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattlqx opened this issue Jan 31, 2025 · 1 comment · Fixed by #339
Closed

coder_parameter doc has examples with country icons that don't exist #336

mattlqx opened this issue Jan 31, 2025 · 1 comment · Fixed by #339
Assignees

Comments

@mattlqx
Copy link

mattlqx commented Jan 31, 2025

https://registry.terraform.io/providers/coder/coder/latest/docs/data-sources/parameter cites:

data "coder_parameter" "example" {
  name        = "Region"
  description = "Specify a region to place your workspace."
  mutable     = false
  type        = "string"
  default     = "asia-central1-a"
  option {
    value = "us-central1-a"
    name  = "US Central"
    icon  = "/icon/usa.svg"
  }
  option {
    value = "asia-central1-a"
    name  = "Asia"
    icon  = "/icon/asia.svg"
  }
}

These country icons do not currently exist in 2.18.4. In fact, when you go to a URL like https://coder.example.com/icon/usa.svg, you'll get a 200 with no body that does some XHR that returns this back to the view:

Image

@matifali
Copy link
Member

matifali commented Feb 7, 2025

We will fix. Thanks @mattlqx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants