Add test cases for startup script behavior

Author: mafredri

provider/agent_test.go

@@ -1,6 +1,7 @@
 package provider_test
 
 import (
+	"regexp"
 	"testing"
 
 	"github.com/coder/terraform-provider-coder/provider"
@@ -36,7 +37,6 @@ func TestAgent(t *testing.T) {
 					motd_file = "/etc/motd"
 					shutdown_script = "echo bye bye"
 					shutdown_script_timeout = 120
-					startup_script_behavior = "blocking"
 				}
 				`,
 			Check: func(state *terraform.State) error {
@@ -58,7 +58,6 @@ func TestAgent(t *testing.T) {
 					"motd_file",
 					"shutdown_script",
 					"shutdown_script_timeout",
-					"startup_script_behavior",
 				} {
 					value := resource.Primary.Attributes[key]
 					t.Logf("%q = %q", key, value)
@@ -71,6 +70,97 @@ func TestAgent(t *testing.T) {
 	})
 }
 
+func TestAgent_StartupScriptBehavior(t *testing.T) {
+	t.Parallel()
+
+	for _, tc := range []struct {
+		Name        string
+		Config      string
+		ExpectError *regexp.Regexp
+		Check       func(state *terraform.ResourceState)
+	}{
+		{
+			Name: "blocking",
+			Config: `
+				resource "coder_agent" "new" {
+					os = "linux"
+					arch = "amd64"
+					startup_script_behavior = "blocking"
+				}
+			`,
+			Check: func(state *terraform.ResourceState) {
+				require.Equal(t, "blocking", state.Primary.Attributes["startup_script_behavior"])
+			},
+		},
+		{
+			Name: "non-blocking",
+			Config: `
+				resource "coder_agent" "new" {
+					os = "linux"
+					arch = "amd64"
+					startup_script_behavior = "non-blocking"
+				}
+			`,
+			Check: func(state *terraform.ResourceState) {
+				require.Equal(t, "non-blocking", state.Primary.Attributes["startup_script_behavior"])
+			},
+		},
+		{
+			Name: "login_before_ready (deprecated)",
+			Config: `
+				resource "coder_agent" "new" {
+					os = "linux"
+					arch = "amd64"
+					login_before_ready = false
+				}
+			`,
+			Check: func(state *terraform.ResourceState) {
+				require.Equal(t, "false", state.Primary.Attributes["login_before_ready"])
+				// startup_script_behavior must be empty, this indicates that
+				// login_before_ready should be used instead.
+				require.Equal(t, "", state.Primary.Attributes["startup_script_behavior"])
+			},
+		},
+		{
+			Name: "no login_before_ready with startup_script_behavior",
+			Config: `
+				resource "coder_agent" "new" {
+					os = "linux"
+					arch = "amd64"
+					login_before_ready = false
+					startup_script_behavior = "blocking"
+				}
+			`,
+			ExpectError: regexp.MustCompile("conflicts with"),
+		},
+	} {
+		tc := tc
+		t.Run(tc.Name, func(t *testing.T) {
+			t.Parallel()
+			resource.Test(t, resource.TestCase{
+				Providers: map[string]*schema.Provider{
+					"coder": provider.New(),
+				},
+				IsUnitTest: true,
+				Steps: []resource.TestStep{{
+					Config:      tc.Config,
+					ExpectError: tc.ExpectError,
+					Check: func(state *terraform.State) error {
+						require.Len(t, state.Modules, 1)
+						require.Len(t, state.Modules[0].Resources, 1)
+						resource := state.Modules[0].Resources["coder_agent.new"]
+						require.NotNil(t, resource)
+						if tc.Check != nil {
+							tc.Check(resource)
+						}
+						return nil
+					},
+				}},
+			})
+		})
+	}
+}
+
 func TestAgent_Instance(t *testing.T) {
 	t.Parallel()
 	resource.Test(t, resource.TestCase{