chore!: remove deprecated attribute from coder_agent

Author: matifali

docs/resources/agent.md

@@ -76,15 +76,12 @@ resource "kubernetes_pod" "dev" {
 - `dir` (String) The starting directory when a user creates a shell session. Defaults to `"$HOME"`.
 - `display_apps` (Block Set, Max: 1) The list of built-in apps to display in the agent bar. (see [below for nested schema](#nestedblock--display_apps))
 - `env` (Map of String) A mapping of environment variables to set inside the workspace.
-- `login_before_ready` (Boolean, **Deprecated**: Configure `startup_script_behavior` instead. This attribute will be removed in a future version of the provider.) This option defines whether or not the user can (by default) login to the workspace before it is ready. Ready means that e.g. the `startup_script` is done and has exited. When enabled, users may see an incomplete workspace when logging in.
 - `metadata` (Block List) Each `metadata` block defines a single item consisting of a key/value pair. This feature is in alpha and may break in future releases. (see [below for nested schema](#nestedblock--metadata))
 - `motd_file` (String) The path to a file within the workspace containing a message to display to users when they login via SSH. A typical value would be `"/etc/motd"`.
 - `order` (Number) The order determines the position of agents in the UI presentation. The lowest order is shown first and agents with equal order are sorted by name (ascending order).
 - `shutdown_script` (String) A script to run before the agent is stopped. The script should exit when it is done to signal that the workspace can be stopped. This option is an alias for defining a `coder_script` resource with `run_on_stop` set to `true`.
-- `shutdown_script_timeout` (Number, **Deprecated**: This feature is deprecated and has no effect. This attribute will be removed in a future version of the provider.) Time in seconds until the agent lifecycle status is marked as timed out during shutdown, this happens when the shutdown script has not completed (exited) in the given time.
 - `startup_script` (String) A script to run after the agent starts. The script should exit when it is done to signal that the agent is ready. This option is an alias for defining a `coder_script` resource with `run_on_start` set to `true`.
 - `startup_script_behavior` (String) This option sets the behavior of the `startup_script`. When set to `"blocking"`, the `startup_script` must exit before the workspace is ready. When set to `"non-blocking"`, the `startup_script` may run in the background and the workspace will be ready immediately. Default is `"non-blocking"`, although `"blocking"` is recommended. This option is an alias for defining a `coder_script` resource with `start_blocks_login` set to `true` (blocking).
-- `startup_script_timeout` (Number, **Deprecated**: This feature is deprecated and has no effect. This attribute will be removed in a future version of the provider.) Time in seconds until the agent lifecycle status is marked as timed out during start, this happens when the startup script has not completed (exited) in the given time.
 - `troubleshooting_url` (String) A URL to a document with instructions for troubleshooting problems with the agent.
 
 ### Read-Only

provider/agent.go

@@ -128,30 +128,12 @@ func agentResource() *schema.Resource {
 				Type:        schema.TypeString,
 				Optional:    true,
 			},
-			"startup_script_timeout": {
-				Type:         schema.TypeInt,
-				Default:      300,
-				ForceNew:     true,
-				Optional:     true,
-				Description:  "Time in seconds until the agent lifecycle status is marked as timed out during start, this happens when the startup script has not completed (exited) in the given time.",
-				Deprecated:   "This feature is deprecated and has no effect. This attribute will be removed in a future version of the provider.",
-				ValidateFunc: validation.IntAtLeast(1),
-			},
 			"shutdown_script": {
 				Type:        schema.TypeString,
 				ForceNew:    true,
 				Optional:    true,
 				Description: "A script to run before the agent is stopped. The script should exit when it is done to signal that the workspace can be stopped. This option is an alias for defining a `coder_script` resource with `run_on_stop` set to `true`.",
 			},
-			"shutdown_script_timeout": {
-				Type:         schema.TypeInt,
-				Default:      300,
-				ForceNew:     true,
-				Optional:     true,
-				Description:  "Time in seconds until the agent lifecycle status is marked as timed out during shutdown, this happens when the shutdown script has not completed (exited) in the given time.",
-				Deprecated:   "This feature is deprecated and has no effect. This attribute will be removed in a future version of the provider.",
-				ValidateFunc: validation.IntAtLeast(1),
-			},
 			"token": {
 				ForceNew:    true,
 				Sensitive:   true,
@@ -179,17 +161,6 @@ func agentResource() *schema.Resource {
 				Optional:    true,
 				Description: "The path to a file within the workspace containing a message to display to users when they login via SSH. A typical value would be `\"/etc/motd\"`.",
 			},
-			"login_before_ready": {
-				// Note: When this is removed, "startup_script_behavior" should
-				// be set to "non-blocking" by default (instead of empty string).
-				Type:          schema.TypeBool,
-				Default:       true,
-				ForceNew:      true,
-				Optional:      true,
-				Description:   "This option defines whether or not the user can (by default) login to the workspace before it is ready. Ready means that e.g. the `startup_script` is done and has exited. When enabled, users may see an incomplete workspace when logging in.",
-				Deprecated:    "Configure `startup_script_behavior` instead. This attribute will be removed in a future version of the provider.",
-				ConflictsWith: []string{"startup_script_behavior"},
-			},
 			"startup_script_behavior": {
 				// Note: Our default value is "non-blocking" but we do not set
 				// it here because we want to be able to differentiate between