chore: sharing_level -> share

Author: deansheather

docs/resources/app.md

@@ -26,12 +26,12 @@ EOF
 }
 
 resource "coder_app" "code-server" {
-  agent_id      = coder_agent.dev.id
-  name          = "VS Code"
-  icon          = data.coder_workspace.me.access_url + "/icons/vscode.svg"
-  url           = "http://localhost:13337"
-  sharing_level = "owner"
-  subdomain     = false
+  agent_id  = coder_agent.dev.id
+  name      = "VS Code"
+  icon      = data.coder_workspace.me.access_url + "/icons/vscode.svg"
+  url       = "http://localhost:13337"
+  share     = "owner"
+  subdomain = false
   healthcheck {
     url       = "http://localhost:13337/healthz"
     interval  = 5
@@ -68,7 +68,7 @@ resource "coder_app" "intellij" {
 - `icon` (String) A URL to an icon that will display in the dashboard. View built-in icons here: https://github.com/coder/coder/tree/main/site/static/icons. Use a built-in icon with `data.coder_workspace.me.access_url + "/icons/<path>"`.
 - `name` (String) A display name to identify the app.
 - `relative_path` (Boolean, Deprecated) Specifies whether the URL will be accessed via a relative path or wildcard. Use if wildcard routing is unavailable. Defaults to true.
-- `sharing_level` (String) Determines the sharing level of the app. Application sharing is an enterprise feature and any values will be ignored (and sharing disabled) if your deployment is not entitled to use application sharing. Valid values are "owner", "template", "authenticated" and "public". Level "owner" disables sharing on the app, so only the workspace owner can access it. Level "template" shares the app with all users that can read the workspace's template. Level "authenticated" shares the app with all authenticated users. Level "public" shares it with any user, including unauthenticated users. Permitted application sharing levels can be controlled via a flag on "coder server". Defaults to "owner" (sharing disabled).
+- `share` (String) Determines the sharing level of the app. Application sharing is an enterprise feature and any values will be ignored (and sharing disabled) if your deployment is not entitled to use application sharing. Valid values are "owner", "template", "authenticated" and "public". Level "owner" disables sharing on the app, so only the workspace owner can access it. Level "template" shares the app with all users that can read the workspace's template. Level "authenticated" shares the app with all authenticated users. Level "public" shares it with any user, including unauthenticated users. Permitted application sharing levels can be controlled via a flag on "coder server". Defaults to "owner" (sharing disabled).
 - `subdomain` (Boolean) Determines whether the app will be accessed via it's own subdomain or whether it will be accessed via a path on Coder. If wildcards have not been setup by the administrator then apps with "subdomain" set to true will not be accessible. Defaults to false.
 - `url` (String) A URL to be proxied to from inside the workspace. Either "command" or "url" may be specified, but not both.
 

examples/resources/coder_app/resource.tf

@@ -11,12 +11,12 @@ EOF
 }
 
 resource "coder_app" "code-server" {
-  agent_id      = coder_agent.dev.id
-  name          = "VS Code"
-  icon          = data.coder_workspace.me.access_url + "/icons/vscode.svg"
-  url           = "http://localhost:13337"
-  sharing_level = "owner"
-  subdomain     = false
+  agent_id  = coder_agent.dev.id
+  name      = "VS Code"
+  icon      = data.coder_workspace.me.access_url + "/icons/vscode.svg"
+  url       = "http://localhost:13337"
+  share     = "owner"
+  subdomain = false
   healthcheck {
     url       = "http://localhost:13337/healthz"
     interval  = 5

provider/app.go

@@ -77,7 +77,7 @@ func appResource() *schema.Resource {
 				ForceNew: true,
 				Optional: true,
 			},
-			"sharing_level": {
+			"share": {
 				Type: schema.TypeString,
 				Description: "Determines the sharing level of the app. " +
 					"Application sharing is an enterprise feature and any " +
@@ -107,7 +107,7 @@ func appResource() *schema.Resource {
 						return nil
 					}
 
-					return diag.Errorf(`invalid app sharing_level %q, must be one of "owner", "template", "authenticated", "public"`, valStr)
+					return diag.Errorf(`invalid app share %q, must be one of "owner", "template", "authenticated", "public"`, valStr)
 				},
 			},
 			"url": {

provider/app_test.go

@@ -56,7 +56,7 @@ func TestApp(t *testing.T) {
 						"subdomain",
 						// Should be set by default even though it isn't
 						// specified.
-						"sharing_level",
+						"share",
 						"url",
 						"healthcheck.0.url",
 						"healthcheck.0.interval",
@@ -90,7 +90,7 @@ func TestApp(t *testing.T) {
 			{
 				name:        "InvalidValue",
 				value:       "blah",
-				expectError: regexp.MustCompile(`invalid app sharing_level "blah"`),
+				expectError: regexp.MustCompile(`invalid app share "blah"`),
 			},
 			{
 				name:        "ExplicitOwner",
@@ -122,7 +122,7 @@ func TestApp(t *testing.T) {
 
 				sharingLine := ""
 				if c.value != "" {
-					sharingLine = fmt.Sprintf("sharing_level = %q", c.value)
+					sharingLine = fmt.Sprintf("share = %q", c.value)
 				}
 				config := fmt.Sprintf(`
 				provider "coder" {
@@ -151,9 +151,9 @@ func TestApp(t *testing.T) {
 					resource := state.Modules[0].Resources["coder_app.code-server"]
 					require.NotNil(t, resource)
 
-					// Read sharing_level and ensure it matches the expected
+					// Read share and ensure it matches the expected
 					// value.
-					value := resource.Primary.Attributes["sharing_level"]
+					value := resource.Primary.Attributes["share"]
 					require.Equal(t, c.expectValue, value)
 					return nil
 				}