Skip to content

bug: coder completion sub-command no longer available #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #10759
johnstcn opened this issue Apr 5, 2023 · 2 comments · Fixed by #7
Closed
Tracked by #10759

bug: coder completion sub-command no longer available #3

johnstcn opened this issue Apr 5, 2023 · 2 comments · Fixed by #7
Assignees
Labels
bug Something isn't working
Milestone

Comments

@johnstcn
Copy link
Member

johnstcn commented Apr 5, 2023

Expected: coder completion <shell> outputs the required completion functions for the given shell.

Actual:

$ ~/bin/coderv2 version
Coder v0.21.3-devel+00d468b9 Wed Apr  5 12:16:05 UTC 2023
https://github.com/coder/coder/commit/00d468b964aafeaa1793438ac29ba439edc30e61

Slim build of Coder, does not support the  server  subcommand.

$ ~/bin/coderv2 completion bash
Usage: coder [global-flags] <subcommand>

Coder v0.21.3-devel+00d468b9 — A tool for provisioning self-hosted development environments with Terraform.
  - Start a Coder server:
[... rest of the help output follows]

This appears to have been introduced in v0.21.0:

$ ./coder_0.21.0_darwin_arm64/coder completion bash 2>&1 | head
Usage: coder [global-flags] <subcommand>

Coder v0.21.0+f88f273 — A tool for provisioning self-hosted development environments with Terraform.
  - Start a Coder server:                                                       

      $ coder server 

  - Get started by creating a template from an example:                         

      $ coder templates init

$ ./coder_0.20.1_darwin_arm64/coder completion bash 2>&1 | head
# bash completion V2 for coder                                -*- shell-script -*-

__coder_debug()
{
    if [[ -n ${BASH_COMP_DEBUG_FILE:-} ]]; then
        echo "$*" >> "${BASH_COMP_DEBUG_FILE}"
    fi
}

# Macs have bash3 for which the bash-completion package doesn't include

@matifali matifali added the bug Something isn't working label Jun 6, 2023
@matifali
Copy link
Member

I no longer see the coder completion subcommand. I think we should add it back.
cc: @bpmct @ammario

@ammario
Copy link
Member

ammario commented Nov 13, 2023

This was intentionally lost during to the clibase refactor.

@ammario ammario removed the bug Something isn't working label Nov 13, 2023
@cdr-bot cdr-bot bot added the bug Something isn't working label Nov 13, 2023
@ammario ammario removed the bug Something isn't working label Nov 13, 2023
@cdr-bot cdr-bot bot added the bug Something isn't working label Nov 13, 2023
@ammario ammario removed the bug Something isn't working label Nov 13, 2023
@ammario ammario transferred this issue from coder/coder Mar 15, 2024
@ammario ammario added this to the v1 milestone Mar 15, 2024
@ammario ammario added the bug Something isn't working label Mar 15, 2024
@ammario ammario self-assigned this Mar 15, 2024
@ammario ammario mentioned this issue Mar 15, 2024
5 tasks
@ammario ammario closed this as completed in #7 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants