Merge pull request #9 from coder/f0ssel/data-race-enum

f0ssel · web-flow · commit 00b6c3f9d4bc · 2024-03-19T12:18:15.000-04:00
fix: prevent data race on enum choices
diff --git a/values.go b/values.go
@@ -493,6 +493,8 @@ type Enum struct {
 }
 
 func EnumOf(v *string, choices ...string) *Enum {
+	// copy choices to avoid data race during unmarshaling
+	choices = append([]string{}, choices...)
 	return &Enum{
 		Choices: choices,
 		Value:   v,

Original file line number	Diff line number	Diff line change
`@@ -493,6 +493,8 @@ type Enum struct {`
`493`	`493`	`}`
`494`	`494`
`495`	`495`	`func EnumOf(v string, choices ...string) Enum {`
	`496`	`+ // copy choices to avoid data race during unmarshaling`
	`497`	`+ choices = append([]string{}, choices...)`
`496`	`498`	`return &Enum{`
`497`	`499`	`Choices: choices,`
`498`	`500`	`Value: v,`