Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Why does cmd + r rebuild the container? #205

Open
teddy-codes opened this issue May 25, 2019 · 4 comments
Open

Why does cmd + r rebuild the container? #205

teddy-codes opened this issue May 25, 2019 · 4 comments

Comments

@teddy-codes
Copy link
Contributor

I was trying to reload the browser to get an extension to work (go tools). It rebuilt the container, so I now have to install them again. Just curious what the thought process was when implementing that.

@ammario
Copy link
Member

ammario commented May 25, 2019

cc @nhooyr

@nhooyr
Copy link
Contributor

nhooyr commented May 25, 2019

Ah that is unfortunate. I thought cmd+r was the most appropriate shortcut because it is usually used to mean "rebuild" but I didn't realize it conflicts with the browser. Will fix this by adding alt to the keybind.

@teddy-codes
Copy link
Contributor Author

Yea, guess alt would be the best. Thanks 😊

@deansheather
Copy link
Member

Wanted to make a PR for this, but it seems that if you change the key binding to Ctrl+Alt+R (via sail.js) it doesn't work in Firefox (works in Chromium, however). Upon further inspection, it looks like Alt just doesn't work in code-server in Firefox, so maybe we should pick a different keybind.

Made a bug report on code-server for Alt not working: coder/code-server#749

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants