Merge pull request #140 from cdr/lowercase-image-name

Nathan Potter · web-flow · commit 1eda0a1cd107 · 2019-05-21T15:18:21.000-05:00
Use lowercase name for docker build
diff --git a/project.go b/project.go
@@ -142,7 +142,8 @@ func (p *project) buildImage() (string, bool, error) {
 		return "", false, nil
 	}
 
-	imageID := p.repo.DockerName()
+	// Docker image names must be completely lowercase.
+	imageID := strings.ToLower(p.repo.DockerName())
 
 	cmdStr := fmt.Sprintf("docker build --network=host -t %v -f %v %v --label %v=%v",
 		imageID, path, p.localDir(), baseImageLabel, imageID,

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,8 @@ func (p *project) buildImage() (string, bool, error) {`
`142`	`142`	`return "", false, nil`
`143`	`143`	`}`
`144`	`144`
`145`		`- imageID := p.repo.DockerName()`
	`145`	`+ // Docker image names must be completely lowercase.`
	`146`	`+ imageID := strings.ToLower(p.repo.DockerName())`
`146`	`147`
`147`	`148`	`cmdStr := fmt.Sprintf("docker build --network=host -t %v -f %v %v --label %v=%v",`
`148`	`149`	`imageID, path, p.localDir(), baseImageLabel, imageID,`