Skip to content

Report errors during parsing stage #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Emyrk opened this issue Mar 5, 2025 · 0 comments
Open

Report errors during parsing stage #22

Emyrk opened this issue Mar 5, 2025 · 0 comments
Assignees
@Emyrk

Comments

@Emyrk
Copy link
Member

Emyrk commented Mar 5, 2025

Parsing errors are logged via slog.Logger

preview/preview.go

Lines 32 to 33 in 26db550

slog.SetLogLoggerLevel(slog.LevelDebug)
slog.SetDefault(slog.New(log.NewHandler(os.Stderr, nil)))

This needs to be corrected to not use the global logger. These warnings/errors should be silenced at worst, and reported at best via diagnostics.
@Emyrk Emyrk self-assigned this Mar 5, 2025
@Kira-Pilot Kira-Pilot changed the title Errors during parsing stage should be reported Report errors during parsing stage Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Emyrk @Kira-Pilot