impl: support for unlimited 'Until Build' setting #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade is needed in order to be able to upgrade the gateway/intellij platform plugins.
This is needed in order to be able to specify "unlimited until builds". IntelliJ Platform Gradle Plugin 2.x is the build system that supersedes the Gradle IntelliJ Plugin 1.x, and this is the version that comes with the ability to provide unlimited until build support. This is a major overhaul of the DSL, I've tested these changes locally with GW 2023.3 (the minimum supported version), and I've also compared the plugin.xml with a previous version to make sure it is generated correctly.
Every time a new GW version is released we need to change the untilBuild setting. With latest IntelliJ Platform Plugin we can provide unlimited upper range with no manual intervention each time a new release is happening.
matifali
reviewed
May 5, 2025
|
It is a valid point, my thinking was that they could go in one shot because the upgrade to Platform plugin 2.x is mandatory. |
f0ssel
approved these changes
May 6, 2025
Use gateway DSL to provide the platform type and version. The plugin verification as well as the platform type depends on the versions in the format "2025.x"
We don't have any UI tests but the test task still fails because it misses junit 4 dependencies. For the unit tests we use kotlin tests library with junit 5 as a backend.
listProductsReleases was renamed to printProductsReleases in version 2.x
Qodana Community for JVM23 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a new GW version is released we need to change the untilBuild setting. With latest IntelliJ Platform Plugin we can provide unlimited upper range with no manual intervention each time a new release is happening.
IntelliJ Platform Gradle Plugin 2.x is the build system that supersedes the Gradle IntelliJ Plugin 1.x, and this is the version that comes with the ability to provide unlimited until build support.
This is a major overhaul of the DSL, I've tested these changes locally with GW 2023.3 (the minimum supported version), and I've also compared the plugin.xml with a previous version to make sure it is generated correctly.