Skip to content

Add labels to workspace actions #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
code-asher opened this issue May 30, 2024 · 2 comments · Fixed by #464
Closed

Add labels to workspace actions #436

code-asher opened this issue May 30, 2024 · 2 comments · Fixed by #464
Assignees
Labels
good first issue Good for newcomers

Comments

@code-asher
Copy link
Member

The play button is especially confusing in the recents window, because it looks like it could be for connecting to the workspace.

We should label it like ⏵︎Start and the others as well, like how we have it in the dashboard.

@code-asher code-asher added the good first issue Good for newcomers label Jul 3, 2024
@bcpeinhardt bcpeinhardt self-assigned this Aug 12, 2024
@bcpeinhardt
Copy link
Collaborator

The flow is a bit weird here. Clicking the link to launch the editor as opposed to the |> button is not intuitive. In the dashboard you have to start the workspace before the button to launch an IDE is even shown, and then when it is shown it's a much larger CTA. I think that's probably what we should shoot for.

@code-asher
Copy link
Member Author

code-asher commented Aug 12, 2024

Yeah it is kinda weird, clicking the link will launch SSH which will start the workspace if it is off, so technically there is no hard requirement to not let the link be clicked even if the workspace is off, but I do see how it seems weird.

It could make sense to start and connect a single button, except that there could be many links per workspace (combinations of IDE plus directory), so there needs to be a way to determine which to launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants