Skip to content

Commit be860cc

Browse files
committed
Clean up some Qodana recommendations
1 parent 03efd05 commit be860cc

File tree

5 files changed

+3
-8
lines changed

5 files changed

+3
-8
lines changed

src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,13 @@ import com.intellij.openapi.application.ApplicationManager
2121
import com.intellij.openapi.components.service
2222
import com.intellij.openapi.diagnostic.Logger
2323
import com.intellij.openapi.ui.DialogWrapper
24-
import com.intellij.openapi.wm.impl.welcomeScreen.WelcomeScreenUIManager
2524
import com.intellij.ui.dsl.builder.panel
2625
import com.intellij.util.ui.JBUI
2726
import com.jetbrains.gateway.api.ConnectionRequestor
2827
import com.jetbrains.gateway.api.GatewayConnectionHandle
2928
import com.jetbrains.gateway.api.GatewayConnectionProvider
3029
import java.net.URL
31-
import javax.swing.Action
32-
import javax.swing.JButton
3330
import javax.swing.JComponent
34-
import javax.swing.JPanel
3531
import javax.swing.border.Border
3632

3733
// In addition to `type`, these are the keys that we support in our Gateway

src/main/kotlin/com/coder/gateway/CoderRemoteConnectionHandle.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ class CoderRemoteConnectionHandle {
288288
conn.instanceFollowRedirects = false
289289
conn.connect()
290290
val code = conn.responseCode
291-
val nextLocation = conn.getHeaderField("Location");
291+
val nextLocation = conn.getHeaderField("Location")
292292
conn.disconnect()
293293
// Redirects are triggered by any code starting with 3 plus a
294294
// location header.

src/main/kotlin/com/coder/gateway/services/CoderSettingsService.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ import com.intellij.openapi.components.service
1515
* prefer using CoderSettingsService over CoderSettingsState directly.
1616
*/
1717
@Service(Service.Level.APP)
18-
class CoderSettingsService() : CoderSettings(service<CoderSettingsState>())
18+
class CoderSettingsService : CoderSettings(service<CoderSettingsState>())

src/main/kotlin/com/coder/gateway/views/steps/CoderWizardStep.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import com.intellij.openapi.wm.impl.welcomeScreen.WelcomeScreenUIManager
66
import com.intellij.ui.dsl.builder.AlignX
77
import com.intellij.ui.dsl.builder.BottomGap
88
import com.intellij.ui.dsl.builder.RightGap
9-
import com.intellij.ui.dsl.builder.TopGap
109
import com.intellij.ui.dsl.builder.panel
1110
import com.intellij.util.ui.JBUI
1211
import com.intellij.util.ui.components.BorderLayoutPanel

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspaceStepView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ class CoderWorkspaceStepView(
313313
executor.getInstalledIDEs().map { ide -> IdeWithStatus(ide.product, ide.buildNumber, IdeStatus.ALREADY_INSTALLED, null, ide.pathToIde, ide.presentableVersion, ide.remoteDevType) }
314314
}
315315
val idesWithStatusJob = cs.async(Dispatchers.IO) {
316-
IntelliJPlatformProduct.values()
316+
IntelliJPlatformProduct.entries
317317
.filter { it.showInGateway }
318318
.flatMap { CachingProductsJsonWrapper.getInstance().getAvailableIdes(it, workspaceOS) }
319319
.map { ide -> IdeWithStatus(ide.product, ide.buildNumber, IdeStatus.DOWNLOAD, ide.download, null, ide.presentableVersion, ide.remoteDevType) }

0 commit comments

Comments
 (0)