Refactor recent connections

- Display workspace name instead of host name.
- Add deployment URL next to the workspace name.
- Add IDE product and build to the connection display (partially
  addresses #400).
- Truncate the path from the head if it is too long.
- Delete invalid recent connections.
- Delete connections with deleted workspaces (closes #396).
- Group connections by deployment URL and then workspace name.  Just a
  DX improvement, so we do not need to do janky things like
  `connections[0].name` under the assumption all the connections share
  the same name.  Could also let us create separate sections per
  deployment in the future, if we need that.
- Display status and errors under the workspace name instead of in a
  tooltip (closes #397).
- Replace config and terminal link with deployment URL
  Both of those things can be derived from the URL.  The main reason for
  this is that there might not be anything in the config when not using
  token authentication.

Author: code-asher

src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt

@@ -31,7 +31,6 @@ import com.coder.gateway.sdk.v2.models.WorkspaceStatus
 import com.coder.gateway.services.CoderRestClientService
 import com.coder.gateway.services.CoderSettingsService
 import com.coder.gateway.util.toURL
-import com.coder.gateway.util.withPath
 import com.coder.gateway.views.steps.CoderWorkspaceProjectIDEStepView
 import com.coder.gateway.views.steps.CoderWorkspacesStepSelection
 import com.intellij.openapi.application.ApplicationManager
@@ -179,10 +178,9 @@ class CoderGatewayConnectionProvider : GatewayConnectionProvider {
                     projectPath = parameters.folder(),
                     ideProductCode = parameters.ideProductCode(),
                     ideBuildNumber = parameters.ideBuildNumber(),
-                    webTerminalLink = client.url.withPath("/@$username/$workspace.name/terminal").toString(),
-                    configDirectory = cli.coderConfigPath.toString(),
                     idePathOnHost = parameters.idePathOnHost(),
                     downloadSource = parameters.ideDownloadLink(),
+                    deploymentURL = deploymentURL,
                     lastOpened = null, // Have not opened yet.
                 )
             }

src/main/kotlin/com/coder/gateway/CoderRemoteConnectionHandle.kt

@@ -80,11 +80,12 @@ class CoderRemoteConnectionHandle {
                         indicator.text = CoderGatewayBundle.message("gateway.connector.coder.connecting.failed.retry", humanizeDuration(remainingMs))
                     },
                 )
-                logger.info("Deploying and starting IDE with $context")
+                logger.info("Starting and connecting to ${parameters.ideName} with $context")
                 // At this point JetBrains takes over with their own UI.
                 @Suppress("UnstableApiUsage") SshDeployFlowUtil.fullDeployCycle(
                     clientLifetime, context, Duration.ofMinutes(10)
                 )
+                logger.info("Adding ${parameters.ideName} for ${parameters.hostname}:${parameters.projectPath} to recent connections")
                 recentConnectionsService.addRecentConnection(parameters.toRecentWorkspaceConnection())
             } catch (e: Exception) {
                 if (isCancellation(e)) {

src/main/kotlin/com/coder/gateway/models/RecentWorkspaceConnection.kt

@@ -17,9 +17,11 @@ class RecentWorkspaceConnection(
     ideBuildNumber: String? = null,
     downloadSource: String? = null,
     idePathOnHost: String? = null,
+    // webTerminalLink and configDirectory are deprecated by deploymentURL.
     webTerminalLink: String? = null,
     configDirectory: String? = null,
     name: String? = null,
+    deploymentURL: String? = null,
 ) : BaseState(), Comparable<RecentWorkspaceConnection> {
     @get:Attribute
     var coderWorkspaceHostname by string()
@@ -35,12 +37,16 @@ class RecentWorkspaceConnection(
     var downloadSource by string()
     @get:Attribute
     var idePathOnHost by string()
+    @Deprecated("Derive from deploymentURL instead.")
     @get:Attribute
     var webTerminalLink by string()
+    @Deprecated("Derive from deploymentURL instead.")
     @get:Attribute
     var configDirectory by string()
     @get:Attribute
     var name by string()
+    @get:Attribute
+    var deploymentURL by string()
 
     init {
         this.coderWorkspaceHostname = coderWorkspaceHostname
@@ -50,8 +56,11 @@ class RecentWorkspaceConnection(
         this.ideBuildNumber = ideBuildNumber
         this.downloadSource = downloadSource
         this.idePathOnHost = idePathOnHost
+        @Suppress("DEPRECATION")
         this.webTerminalLink = webTerminalLink
+        @Suppress("DEPRECATION")
         this.configDirectory = configDirectory
+        this.deploymentURL = deploymentURL
         this.name = name
     }
 

src/main/kotlin/com/coder/gateway/models/WorkspaceProjectIDE.kt

@@ -16,9 +16,11 @@ import com.jetbrains.gateway.ssh.deploy.TransferProgressTracker
 import com.jetbrains.gateway.ssh.util.validateIDEInstallPath
 import org.zeroturnaround.exec.ProcessExecutor
 import java.net.URI
+import java.nio.file.Path
 import java.time.Duration
 import java.time.LocalDateTime
 import java.time.format.DateTimeFormatter
+import kotlin.io.path.name
 
 private val localTimeFormatter = DateTimeFormatter.ofPattern("yyyy-MMM-dd HH:mm")
 
@@ -266,15 +268,37 @@ class WorkspaceProjectIDE(
  * on a workspace.  Throw if invalid.
  */
 fun RecentWorkspaceConnection.toWorkspaceProjectIDE(): WorkspaceProjectIDE {
+    val hostname = coderWorkspaceHostname
+    @Suppress("DEPRECATION")
+    val dir = configDirectory
     return WorkspaceProjectIDE.fromInputs(
-        name = name,
-        hostname = coderWorkspaceHostname,
+        // The name was added to query the workspace status on the recent
+        // connections page, so it could be missing.  Try to get it from the
+        // host name.
+        name = if (name.isNullOrBlank() && !hostname.isNullOrBlank()) {
+            hostname
+                .removePrefix("coder-jetbrains--")
+                .removeSuffix("--${hostname.split("--").last()}")
+        } else name,
+        hostname = hostname,
         projectPath = projectPath,
         ideProductCode = ideProductCode,
         ideBuildNumber = ideBuildNumber,
         idePathOnHost = idePathOnHost,
         downloadSource = downloadSource,
-        deploymentURL = deploymentURL,
+        // The deployment URL was added to replace storing the web terminal link
+        // and config directory, as we can construct both from the URL and the
+        // config directory might not always exist (for example, authentication
+        // might happen with mTLS, and we can skip login which normally creates
+        // the config directory).  For backwards compatibility with existing
+        // entries, extract the URL from the config directory or host name.
+        deploymentURL = if (deploymentURL.isNullOrBlank()) {
+            if (!dir.isNullOrBlank()) {
+                "https://${Path.of(dir).parent.name}"
+            } else if (!hostname.isNullOrBlank()) {
+                "https://${hostname.split("--").last()}"
+            } else deploymentURL
+        } else deploymentURL,
         lastOpened = lastOpened,
     )
 }