PortMatcher code review feedback

Author: aaronlehmann

src/main/kotlin/com/coder/jetbrains/matcher/PortMatcher.kt

@@ -7,11 +7,7 @@ class PortMatcher(private val rule: String) {
         data class RegexPort(val pattern: Regex) : MatchRule()
     }
 
-    private val parsedRule: MatchRule
-
-    init {
-        parsedRule = parseRule(rule)
-    }
+    private val parsedRule: MatchRule = parseRule(rule)
 
     fun matches(port: Int): Boolean {
         return when (parsedRule) {
@@ -33,12 +29,10 @@ class PortMatcher(private val rule: String) {
                 MatchRule.SinglePort(port)
             }
             // Try parsing as port range (e.g., "40000-55000")
-            portPart.matches("^\\d+-\\d+$".toRegex()) -> {
+            portPart.matches("^\\d+\\s*-\\s*\\d+$".toRegex()) -> {
                 val (start, end) = portPart.split('-')
                     .map { it.trim().toInt() }
-                validatePort(start)
-                validatePort(end)
-                require(start <= end) { "Invalid port range: start must be less than or equal to end" }
+                validatePortRange(start, end)
                 MatchRule.PortRange(start, end)
             }
             // If not a single port or range, treat as regex
@@ -56,7 +50,9 @@ class PortMatcher(private val rule: String) {
         require(port in 0..65535) { "Port number must be between 0 and 65535, got: $port" }
     }
 
-    companion object {
-        const val MAX_PORT = 65535
+    private fun validatePortRange(start: Int, end: Int) {
+        validatePort(start)
+        validatePort(end)
+        require(start <= end) { "Invalid port range: start must be less than or equal to end" }
     }
 }

src/test/kotlin/com/coder/jetbrains/matcher/PortMatcherTest.kt

@@ -32,6 +32,13 @@ class PortMatcherTest {
         assertFalse(matcher.matches(55001))
     }
 
+    @Test
+    fun `test port range with whitespace`() {
+        val matcher = PortMatcher("20021  - 20024")
+        assertFalse(matcher.matches(20000))
+        assertTrue(matcher.matches(20022))
+    }
+
     @Test
     fun `test regex`() {
         val matcher = PortMatcher("800[1-9]")