Skip to content

Dockerfile when using ARG in FROM doesn't work #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bilby91 opened this issue Jul 18, 2023 · 4 comments · Fixed by #45
Closed

Dockerfile when using ARG in FROM doesn't work #35

bilby91 opened this issue Jul 18, 2023 · 4 comments · Fixed by #45

Comments

@bilby91
Copy link

bilby91 commented Jul 18, 2023

I was testing the project using this devcontainer specification and envbuilder is failing to build the following Dockerfile => https://github.com/crunchloop/rails-interview/blob/main/.devcontainer/Dockerfile#L3

It throws and error indicating that it can't parse the image. This is working fine with devcontainer cli. I'm going to post the error soon since I don't have it with me.

Removing the VARIANT and hard coding the value made it work.

@bilby91 bilby91 changed the title Dockerfile with using ARG in FROM doesn't work Dockerfile when using ARG in FROM doesn't work Jul 18, 2023
@bilby91
Copy link
Author

bilby91 commented Jul 18, 2023

Got some time to capture the error:

2023-07-18T20:22:02.964 app[91857917c5d783] eze [info] error: compile devcontainer.json: parse image from dockerfile: parse image ref "mcr.microsoft.com/devcontainers/ruby:${VARIANT}": could not parse reference: mcr.microsoft.com/devcontainers/ruby:${VARIANT}

@kylecarbs
Copy link
Member

Ahh, will fix this!

@bilby91
Copy link
Author

bilby91 commented Jul 27, 2023

@kylecarbs Confirmed that this is working now!

@kylecarbs
Copy link
Member

Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants