-
Notifications
You must be signed in to change notification settings - Fork 43
migrate to upstream kaniko #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@johnstcn with 43b5b37, is the only remaining issue the output capture? Would it be feasible to run Kaniko as an external program and capture the output that way? Or are we tweaking the behavior in a way that can't be adjusted via env/flags? I think it's still valuable if we can embed Kaniko, but that's quite easily achieved via: import (
"os"
"github.com/GoogleContainerTools/kaniko/cmd/executor/cmd"
)
func main() {
if err := cmd.RootCmd.Execute(); err != nil {
os.Exit(1)
}
} The benefit of this would be that we can support both modes of operation, external or embedded Kaniko. |
I believe that's the only reason. I think the change you propose is possible as a refactor. |
Alright, thanks for confirming. OTOH, with #124 we'll be still need to maintain a fork. 😅 |
We'll need to stay on our own fork for the foreseeable future. |
We are currently on a fork of github.com/GoogleContainerTools/kaniko (github.com/coder/kaniko).
Our fork includes some extra changes that are not included in upstream Kaniko:
Add options for capturing run output to
GetCommand
(coder/kaniko@30ddbe5)Set default UserID and GroupID to 0:0 (coder/kaniko@6431577) (related to COPY does not default UID to 0 GoogleContainerTools/kaniko#1921)The text was updated successfully, but these errors were encountered: