Skip to content

Does not search all specified devcontainer locations #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #132
bpmct opened this issue Mar 29, 2024 · 0 comments · Fixed by #134
Closed
Tracked by #132

Does not search all specified devcontainer locations #116

bpmct opened this issue Mar 29, 2024 · 0 comments · Fixed by #134
Assignees
@mtojek
Milestone
envbuilder v1.0

Comments

@bpmct
Copy link
Member

bpmct commented Mar 29, 2024

It seems like it defaults to looking in .devconatiner/devcontainer.json for the file, but does not search all 3 accepted locations in the spec: https://containers.dev/implementors/spec/#devcontainerjson

For example, https://github.com/google/gvisor does not work with the default envbuilder repo passed
@coder-labeler coder-labeler bot added the bug label Mar 29, 2024
@bpmct bpmct added this to the envbuilder v1.0 milestone Apr 10, 2024
@bpmct bpmct mentioned this issue Apr 18, 2024
Closed
36 tasks
@mtojek mtojek self-assigned this Apr 19, 2024
@mtojek mtojek mentioned this issue Apr 22, 2024
Merged
@matifali matifali removed the bug label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
envbuilder v1.0
Development

Successfully merging a pull request may close this issue.

feat: locate devcontainer.json in multiple places coder/envbuilder
3 participants
@matifali @mtojek @bpmct