Skip to content

Commit 734cefc

Browse files
committed
RED: update integration tests to reproduce issue
1 parent dac4d24 commit 734cefc

File tree

1 file changed

+29
-10
lines changed

1 file changed

+29
-10
lines changed

integration/integration_test.go

+29-10
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import (
4141
"github.com/google/go-containerregistry/pkg/registry"
4242
"github.com/google/go-containerregistry/pkg/v1/remote"
4343
"github.com/google/go-containerregistry/pkg/v1/remote/transport"
44+
"github.com/google/uuid"
4445
"github.com/stretchr/testify/assert"
4546
"github.com/stretchr/testify/require"
4647
)
@@ -402,19 +403,37 @@ func TestBuildIgnoreVarRunSecrets(t *testing.T) {
402403
},
403404
})
404405
dir := t.TempDir()
405-
err := os.WriteFile(filepath.Join(dir, "secret"), []byte("test"), 0o644)
406+
secretVal := uuid.NewString()
407+
err := os.WriteFile(filepath.Join(dir, "secret"), []byte(secretVal), 0o644)
406408
require.NoError(t, err)
407-
ctr, err := runEnvbuilder(t, options{
408-
env: []string{
409-
envbuilderEnv("GIT_URL", srv.URL),
410-
envbuilderEnv("DOCKERFILE_PATH", "Dockerfile"),
411-
},
412-
binds: []string{fmt.Sprintf("%s:/var/run/secrets", dir)},
409+
410+
t.Run("ReadWrite", func(t *testing.T) {
411+
ctr, err := runEnvbuilder(t, options{
412+
env: []string{
413+
envbuilderEnv("GIT_URL", srv.URL),
414+
envbuilderEnv("DOCKERFILE_PATH", "Dockerfile"),
415+
},
416+
binds: []string{fmt.Sprintf("%s:/var/run/secrets:rw", dir)},
417+
})
418+
require.NoError(t, err)
419+
420+
output := execContainer(t, ctr, "cat /var/run/secrets/secret")
421+
require.Equal(t, secretVal, strings.TrimSpace(output))
413422
})
414-
require.NoError(t, err)
415423

416-
output := execContainer(t, ctr, "echo hello")
417-
require.Equal(t, "hello", strings.TrimSpace(output))
424+
t.Run("ReadOnly", func(t *testing.T) {
425+
ctr, err := runEnvbuilder(t, options{
426+
env: []string{
427+
envbuilderEnv("GIT_URL", srv.URL),
428+
envbuilderEnv("DOCKERFILE_PATH", "Dockerfile"),
429+
},
430+
binds: []string{fmt.Sprintf("%s:/var/run/secrets:ro", dir)},
431+
})
432+
require.NoError(t, err)
433+
434+
output := execContainer(t, ctr, "cat /var/run/secrets/secret")
435+
require.Equal(t, secretVal, strings.TrimSpace(output))
436+
})
418437
}
419438

420439
func TestBuildWithSetupScript(t *testing.T) {

0 commit comments

Comments
 (0)