Skip to content

Allow coder_metadata to set the icon for a resource #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattlqx opened this issue Aug 12, 2022 · 4 comments · Fixed by #4020
Closed

Allow coder_metadata to set the icon for a resource #3487

mattlqx opened this issue Aug 12, 2022 · 4 comments · Fixed by #4020
Assignees
@BrunoQuaresma
Labels
api Area: HTTP API site Area: frontend dashboard

Comments

@mattlqx
Copy link

mattlqx commented Aug 12, 2022

Screen Shot 2022-08-12 at 8 37 28 AM

Some (most?) Terraform resources show up as a ? icon in the workspace state display. It would be nice to allow setting this either arbitrarily, or from a pre-defined icon set.
@BrunoQuaresma BrunoQuaresma added needs decision Needs a higher-level decision to be unblocked. needs grooming labels Aug 12, 2022
@bpmct
Copy link
Member

bpmct commented Aug 12, 2022

Huge fan of this! We can probably support an arbitrary icon since we have a prior pattern for this with the coder_app resource in Terraform.

@kylecarbs kylecarbs added feature api Area: HTTP API site Area: frontend dashboard and removed needs grooming needs decision Needs a higher-level decision to be unblocked. labels Aug 22, 2022
@BrunoQuaresma
Copy link
Collaborator

@bpmct @mattlqx would you be ok if we use the Material Icons for this?

@BrunoQuaresma BrunoQuaresma self-assigned this Sep 8, 2022
@bpmct
Copy link
Member

bpmct commented Sep 8, 2022 •
edited
Loading

@BrunoQuaresma sounds good.

@BrunoQuaresma BrunoQuaresma mentioned this issue Sep 9, 2022
Merged
@BrunoQuaresma
Copy link
Collaborator

Following the discussion on this PR coder/terraform-provider-coder#48 we changed this feature a bit to accept image URLs instead of Material UI icons.

@BrunoQuaresma BrunoQuaresma mentioned this issue Sep 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
api Area: HTTP API site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Show custom resource icons coder/coder
4 participants
@mattlqx @BrunoQuaresma @kylecarbs @bpmct