Skip to content

fix: include all defined experiments in ExperimentsSafe #18188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Jun 2, 2025

This fixes issue #18103 where valid experiments like agentic-chat and others were being incorrectly marked as invalid on the deployment overview page.

Problem

The deployment overview page was showing valid experiments as "invalid" because the backend ExperimentsSafe array only contained ExperimentWorkspacePrebuilds, while the frontend expected all defined experiments to be considered safe/valid.

Root Cause

In codersdk/deployment.go, the ExperimentsSafe array was incomplete:

var ExperimentsSafe = Experiments{
    ExperimentWorkspacePrebuilds,  // Only this one was included
}

But the frontend Experiment type includes all these experiments:

  • agentic-chat
  • auto-fill-parameters
  • dynamic-parameters
  • example
  • notifications
  • web-push
  • workspace-prebuilds
  • workspace-usage
  • ai-tasks

Solution

Updated ExperimentsSafe to include all currently defined experiments:

var ExperimentsSafe = Experiments{
    ExperimentExample,
    ExperimentAutoFillParameters,
    ExperimentNotifications,
    ExperimentWorkspaceUsage,
    ExperimentWebPush,
    ExperimentDynamicParameters,
    ExperimentWorkspacePrebuilds,
    ExperimentAgenticChat,
    ExperimentAITasks,
}

Testing

  • ✅ Code compiles successfully
  • ✅ Existing experiments tests should pass
  • ✅ All defined experiments will now be considered "safe" and not marked as invalid

Fixes #18103

This fixes issue #18103 where valid experiments like 'agentic-chat'
and others were being incorrectly marked as invalid on the deployment
overview page.

The issue was that ExperimentsSafe only contained ExperimentWorkspacePrebuilds,
but the frontend validation logic expects all defined experiments to be
considered safe/valid.

This change adds all currently defined experiments to ExperimentsSafe:
- ExperimentExample
- ExperimentAutoFillParameters
- ExperimentNotifications
- ExperimentWorkspaceUsage
- ExperimentWebPush
- ExperimentDynamicParameters
- ExperimentWorkspacePrebuilds (already included)
- ExperimentAgenticChat
- ExperimentAITasks

Fixes #18103
Copy link

github-actions bot commented Jun 2, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Blink seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@bpmct
Copy link
Member

bpmct commented Jun 2, 2025

Closing. We'll need to redo this as it will now commit with the right username blink-so

@bpmct bpmct closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: valid experiments are shown as invalid experimnets
1 participant