fix: include all defined experiments in ExperimentsSafe #18188
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #18103 where valid experiments like
agentic-chat
and others were being incorrectly marked as invalid on the deployment overview page.Problem
The deployment overview page was showing valid experiments as "invalid" because the backend
ExperimentsSafe
array only containedExperimentWorkspacePrebuilds
, while the frontend expected all defined experiments to be considered safe/valid.Root Cause
In
codersdk/deployment.go
, theExperimentsSafe
array was incomplete:But the frontend
Experiment
type includes all these experiments:agentic-chat
auto-fill-parameters
dynamic-parameters
example
notifications
web-push
workspace-prebuilds
workspace-usage
ai-tasks
Solution
Updated
ExperimentsSafe
to include all currently defined experiments:Testing
Fixes #18103