Skip to content

Commit 1d81e7c

Browse files
authored
refactor: simplify build and draft release jobs (#30)
- and also fix the zip and release notes publish - there is no need to unzip and then later re-zip files to be published as draft because Kotlin does the zip in the first place, we just need to upload it and download it in the jobs that need it. - similar, release note files have to be shared between jobs by upload&download
1 parent 2c8014b commit 1d81e7c

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

.github/workflows/build.yml

+18-14
Original file line numberDiff line numberDiff line change
@@ -77,22 +77,18 @@ jobs:
7777
- name: Run Build
7878
run: ./gradlew clean pluginZip --info
7979

80-
# Prepare plugin archive content for creating artifact
81-
- name: Prepare Plugin Artifact
82-
id: artifact
83-
shell: bash
84-
run: |
85-
cd ${{ github.workspace }}/build/distributions
86-
FILENAME=$(ls *.zip)
87-
unzip "$FILENAME" -d content
88-
echo "filename=${FILENAME:0:-4}" >> $GITHUB_OUTPUT
89-
9080
# Store already-built plugin as an artifact for downloading
9181
- name: Upload artifact
9282
uses: actions/upload-artifact@v4
9383
with:
94-
name: ${{ steps.artifact.outputs.filename }}
95-
path: ./build/distributions/content/*/*
84+
name: zip-artifacts
85+
path: ./build/distributions/*.zip
86+
87+
- name: Upload Release Notes
88+
uses: actions/upload-artifact@v4
89+
with:
90+
name: release-notes
91+
path: RELEASE_NOTES.md
9692

9793
# Prepare a draft release for GitHub Releases page for the manual verification
9894
# If accepted and published, release workflow would be triggered
@@ -119,8 +115,16 @@ jobs:
119115
- name: Download Build Artifacts
120116
uses: actions/download-artifact@v4
121117
with:
122-
name: release-artifacts
118+
name: zip-artifacts
123119
path: artifacts/
120+
- name: Display the Zip files that are going to be attached
121+
run: ls -R artifacts/
122+
123+
- name: Download Release Notes
124+
uses: actions/download-artifact@v4
125+
with:
126+
name: release-notes
127+
path: notes/
124128

125129
# Create new release draft - which is not publicly visible and requires manual acceptance
126130
- name: Create Release Draft
@@ -131,4 +135,4 @@ jobs:
131135
--draft artifacts/* \
132136
--target ${GITHUB_REF_NAME} \
133137
--title "v${{ needs.build.outputs.version }}" \
134-
--notes-file RELEASE_NOTES.md
138+
--notes-file notes/RELEASE_NOTES.md

0 commit comments

Comments
 (0)