Skip to content

Commit c92ba0b

Browse files
committed
small changes
1 parent 2f8f3a1 commit c92ba0b

File tree

4 files changed

+4
-12
lines changed

4 files changed

+4
-12
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ jobs:
177177
# to GitHub and then making a PR in a different repo.
178178
WINGET_GH_TOKEN: ${{ secrets.CDRCI_GITHUB_TOKEN }}
179179

180-
180+
181181
- name: Comment on PR
182182
run: |
183183
# wait 30 seconds

App/App.csproj

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
<SelfContained>false</SelfContained>
3434
</PropertyGroup>
3535

36-
<ItemGroup>
37-
<None Remove="Views\Pages\UpdaterDownloadProgressMainPage.xaml" />
38-
</ItemGroup>
39-
4036
<ItemGroup>
4137
<Content Include="coder.ico" />
4238
<EmbeddedResource Include="Assets\changelog.css" />
@@ -90,10 +86,4 @@
9086
<ProjectReference Include="..\Vpn.Proto\Vpn.Proto.csproj" />
9187
<ProjectReference Include="..\Vpn\Vpn.csproj" />
9288
</ItemGroup>
93-
94-
<ItemGroup>
95-
<Page Update="Views\Pages\UpdaterDownloadProgressMainPage.xaml">
96-
<Generator>MSBuild:Compile</Generator>
97-
</Page>
98-
</ItemGroup>
9989
</Project>

App/Services/UpdateController.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ public SparkleUpdateController(ILogger<SparkleUpdateController> logger, IOptions
101101

102102
_sparkle.CloseApplicationAsync += SparkleOnCloseApplicationAsync;
103103

104-
// TODO: user preference for automatic checking
104+
// TODO: user preference for automatic checking. Remember to
105+
// StopLoop/StartLoop if it changes.
105106
#if !DEBUG || true
106107
_ = _sparkle.StartLoop(true, UpdateCheckInterval);
107108
#endif

App/ViewModels/UpdaterUpdateAvailableViewModel.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ public async Task Changelog_Loaded(object sender, RoutedEventArgs e)
189189
settings.IsStatusBarEnabled = false;
190190

191191
// Hijack navigation to prevent links opening in the web view.
192+
// TODO: block new windows as well
192193
webView.CoreWebView2.NavigationStarting += (_, e) =>
193194
{
194195
// webView.NavigateToString uses data URIs, so allow those to work.

0 commit comments

Comments
 (0)