chore: check server version on sign-in and launch (#43)

Updates CredentialModel to have an additional state `Unknown` during
startup while credentials are validated in the background asynchronously
(15s timeout).

While loading credentials on startup, the tray app shows a loading
message.

While updating credentials, we now check that the server version falls
in our expected range.

The sign in page now uses a WinUI 3 Dialog to show errors.

Closes #42

Author: deansheather

.github/workflows/ci.yaml

@@ -11,6 +11,7 @@ on:
 jobs:
   fmt:
     runs-on: windows-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
       - name: Setup dotnet
@@ -26,6 +27,7 @@ jobs:
 
   test:
     runs-on: windows-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
       - name: Setup dotnet
@@ -34,13 +36,36 @@ jobs:
           dotnet-version: 8.0.x
           cache: true
           cache-dependency-path: '**/packages.lock.json'
+      - name: Install Windows App SDK Runtime
+        shell: pwsh
+        run: |
+          $ErrorActionPreference = "Stop"
+
+          $filename = ".\WindowsAppRuntimeInstall-x64.exe"
+          $url = "https://download.microsoft.com/download/7a3a6a44-b07e-4ca5-8b63-2de185769dbc/WindowsAppRuntimeInstall-x64.exe" # 1.6.5 (1.6.250205002)
+          & curl.exe --progress-bar --show-error --fail --location --output $filename $url
+          if ($LASTEXITCODE -ne 0) { throw "Failed to download Windows App SDK" }
+
+          $process = Start-Process -FilePath $filename -ArgumentList "--quiet --force" -NoNewWindow -Wait -PassThru
+          if ($process.ExitCode -ne 0) { throw "Failed to install Windows App SDK: exit code is $($process.ExitCode)" }
       - name: dotnet restore
         run: dotnet restore --locked-mode
       - name: dotnet test
-        run: dotnet test --no-restore
+        run: dotnet test --no-restore --blame-hang --blame-hang-dump-type full --blame-hang-timeout 2m -p:Platform=x64
+      - name: Upload test binaries and TestResults
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: test-results
+          retention-days: 1
+          path: |
+            ./**/bin
+            ./**/obj
+            ./**/TestResults
 
   build:
     runs-on: windows-latest
+    timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
       - name: Setup dotnet

.github/workflows/release.yaml

@@ -18,6 +18,7 @@ permissions:
 jobs:
   release:
     runs-on: ${{ github.repository_owner == 'coder' && 'windows-latest-16-cores' || 'windows-latest' }}
+    timeout-minutes: 15
 
     steps:
     - uses: actions/checkout@v4

App/App.xaml.cs

@@ -1,5 +1,7 @@
 using System;
+using System.Threading;
 using System.Threading.Tasks;
+using Coder.Desktop.App.Models;
 using Coder.Desktop.App.Services;
 using Coder.Desktop.App.ViewModels;
 using Coder.Desktop.App.Views;
@@ -26,6 +28,7 @@ public App()
         services.AddTransient<SignInWindow>();
 
         // TrayWindow views and view models
+        services.AddTransient<TrayWindowLoadingPage>();
         services.AddTransient<TrayWindowDisconnectedViewModel>();
         services.AddTransient<TrayWindowDisconnectedPage>();
         services.AddTransient<TrayWindowLoginRequiredViewModel>();
@@ -45,17 +48,29 @@ public async Task ExitApplication()
     {
         _handleWindowClosed = false;
         Exit();
-        var rpcManager = _services.GetRequiredService<IRpcController>();
+        var rpcController = _services.GetRequiredService<IRpcController>();
         // TODO: send a StopRequest if we're connected???
-        await rpcManager.DisposeAsync();
+        await rpcController.DisposeAsync();
         Environment.Exit(0);
     }
 
     protected override void OnLaunched(LaunchActivatedEventArgs args)
     {
-        var trayWindow = _services.GetRequiredService<TrayWindow>();
+        // Start connecting to the manager in the background.
+        var rpcController = _services.GetRequiredService<IRpcController>();
+        if (rpcController.GetState().RpcLifecycle == RpcLifecycle.Disconnected)
+            // Passing in a CT with no cancellation is desired here, because
+            // the named pipe open will block until the pipe comes up.
+            _ = rpcController.Reconnect(CancellationToken.None);
+
+        // Load the credentials in the background. Even though we pass a CT
+        // with no cancellation, the method itself will impose a timeout on the
+        // HTTP portion.
+        var credentialManager = _services.GetRequiredService<ICredentialManager>();
+        _ = credentialManager.LoadCredentials(CancellationToken.None);
 
         // Prevent the TrayWindow from closing, just hide it.
+        var trayWindow = _services.GetRequiredService<TrayWindow>();
         trayWindow.Closed += (sender, args) =>
         {
             if (!_handleWindowClosed) return;

App/Models/CredentialModel.cs

@@ -2,16 +2,24 @@ namespace Coder.Desktop.App.Models;
 
 public enum CredentialState
 {
+    // Unknown means "we haven't checked yet"
+    Unknown,
+
+    // Invalid means "we checked and there's either no saved credentials or they are not valid"
     Invalid,
+
+    // Valid means "we checked and there are saved credentials and they are valid"
     Valid,
 }
 
 public class CredentialModel
 {
-    public CredentialState State { get; set; } = CredentialState.Invalid;
+    public CredentialState State { get; init; } = CredentialState.Unknown;
+
+    public string? CoderUrl { get; init; }
+    public string? ApiToken { get; init; }
 
-    public string? CoderUrl { get; set; }
-    public string? ApiToken { get; set; }
+    public string? Username { get; init; }
 
     public CredentialModel Clone()
     {
@@ -20,6 +28,7 @@ public CredentialModel Clone()
             State = State,
             CoderUrl = CoderUrl,
             ApiToken = ApiToken,
+            Username = Username,
         };
     }
 }