feat: add menubar tray #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/menubar
branch
2 times, most recently
from
aaa4c62 to
5ce4eae
Compare
ethanndickson
force-pushed
the
ethan/menubar
branch
from
5ce4eae to
a87e8b5
Compare
ethanndickson
commented
Dec 5, 2024
| "originHash" : "726475d6c2c0355de7a4de72708853eaf53eb295e791efe2cc4b8eb5ce4e9ae8", | ||
| "pins" : [ | ||
| { | ||
| "identity" : "fluid-menu-bar-extra", |
There was a problem hiding this comment.
This is a drop-in replacement for SwiftUI MenuBarExtra, since the original kinda just sucks and doesn't handle resizing very well. It's used by https://github.com/Shopify/tophat, and is designed so that if MenuBarExtra ever improves, you can just swap back.
There was a problem hiding this comment.
These are UI unit tests for different views (SwiftUI components). You cannot unit test in UITests, you can only simulate interactions with a built executable (of which there is currently no point doing).
ethanndickson
force-pushed
the
ethan/menubar
branch
from
a87e8b5 to
d7b1356
Compare
spikecurtis
approved these changes
Dec 5, 2024
deansheather
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7.
codervpn-happy.mov
codervpn-error.mov