chore: remove "VPN" from setting description

Change-Id: If1e0c81dd7188eea92f814424a997944a07caf86
Signed-off-by: Thomas Kosiewski <[email protected]>

Author: ThomasK33

Coder Desktop/Coder Desktop/NetworkExtension.swift

@@ -50,7 +50,7 @@ extension CoderVPNService {
         logger.debug("inserting new tunnel")
 
         let tm = NETunnelProviderManager()
-        tm.localizedDescription = "CoderVPN"
+        tm.localizedDescription = "Coder"
         tm.protocolConfiguration = proto
 
         logger.debug("saving new tunnel")

Coder Desktop/Coder Desktop/Views/Settings/GeneralTab.swift

@@ -10,7 +10,7 @@ struct GeneralTab: View {
             }
             Section {
                 Toggle(isOn: $state.stopVPNOnQuit) {
-                    Text("Stop VPN on Quit")
+                    Text("Stop Coder network connection on Quit")
                 }
             }
         }.formStyle(.grouped)

Coder Desktop/Coder Desktop/Views/VPNMenu.swift

@@ -20,7 +20,7 @@ struct VPNMenu<VPN: VPNService>: View {
                         }
                         }
                     )) {
-                        Text("CoderVPN")
+                        Text("Coder")
                             .frame(maxWidth: .infinity, alignment: .leading)
                             .font(.body.bold())
                             .foregroundColor(.primary)

Coder Desktop/Coder Desktop/Views/VPNState.swift

@@ -14,18 +14,18 @@ struct VPNState<VPN: VPNService>: View {
                     .font(.body)
                     .foregroundStyle(.secondary)
             case (_, false):
-                Text("Sign in to use CoderVPN")
+                Text("Sign in to use Coder Desktop")
                     .font(.body)
                     .foregroundColor(.secondary)
             case (.disabled, _):
-                Text("Enable CoderVPN to see workspaces")
+                Text("Enable Coder to see workspaces")
                     .font(.body)
                     .foregroundStyle(.secondary)
             case (.connecting, _), (.disconnecting, _):
                 HStack {
                     Spacer()
                     ProgressView(
-                        vpn.state == .connecting ? "Starting CoderVPN..." : "Stopping CoderVPN..."
+                        vpn.state == .connecting ? "Starting Coder..." : "Stopping Coder..."
                     ).padding()
                     Spacer()
                 }

Coder Desktop/Coder DesktopTests/VPNMenuTests.swift

@@ -24,7 +24,7 @@ struct VPNMenuTests {
             try await sut.inspection.inspect { view in
                 let toggle = try view.find(ViewType.Toggle.self)
                 #expect(toggle.isDisabled())
-                #expect(throws: Never.self) { try view.find(text: "Sign in to use CoderVPN") }
+                #expect(throws: Never.self) { try view.find(text: "Sign in to use Coder Desktop") }
                 #expect(throws: Never.self) { try view.find(button: "Sign in") }
             }
         }

Coder Desktop/Coder DesktopTests/VPNStateTests.swift

@@ -26,7 +26,7 @@ struct VPNStateTests {
         try await ViewHosting.host(view) {
             try await sut.inspection.inspect { view in
                 #expect(throws: Never.self) {
-                    try view.find(text: "Enable CoderVPN to see workspaces")
+                    try view.find(text: "Enable Coder to see workspaces")
                 }
             }
         }
@@ -39,7 +39,7 @@ struct VPNStateTests {
         try await ViewHosting.host(view) {
             try await sut.inspection.inspect { view in
                 let progressView = try view.find(ViewType.ProgressView.self)
-                #expect(try progressView.labelView().text().string() == "Starting CoderVPN...")
+                #expect(try progressView.labelView().text().string() == "Starting Coder...")
             }
         }
     }
@@ -51,7 +51,7 @@ struct VPNStateTests {
         try await ViewHosting.host(view) {
             try await sut.inspection.inspect { view in
                 let progressView = try view.find(ViewType.ProgressView.self)
-                #expect(try progressView.labelView().text().string() == "Stopping CoderVPN...")
+                #expect(try progressView.labelView().text().string() == "Stopping Coder...")
             }
         }
     }

Coder Desktop/VPN/Info.plist

@@ -4,6 +4,8 @@
 <dict>
 	<key>NSSystemExtensionUsageDescription</key>
 	<string></string>
+  <key>CFBundleDisplayName</key>
+	<string>Coder Desktop Network Extension</string>
 	<key>NetworkExtension</key>
 	<dict>
 		<key>NEMachServiceName</key>