lint & fmt

Author: ethanndickson

.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
-          fetch-depth: 0
+          fetch-depth: 1
       - name: Switch XCode Version
         uses: maxim-lobanov/setup-xcode@v1
         with:
@@ -37,7 +37,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
-          fetch-depth: 0
+          fetch-depth: 1
       - run: |
           make fmt
         working-directory: Coder Desktop
@@ -48,7 +48,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
-          fetch-depth: 0
+          fetch-depth: 1
       - name: Install Swiftlint
         run: |
           brew install swiftlint

Coder Desktop/Coder Desktop/Theme.swift

@@ -8,5 +8,6 @@ enum Theme {
 
         static let rectCornerRadius: CGFloat = 4
     }
+
     static let defaultVisibleAgents = 5
 }

Coder Desktop/Coder Desktop/Views/Agents.swift

@@ -6,7 +6,7 @@ struct Agents<VPN: VPNService, S: Session>: View {
     @State private var viewAll = false
     private let defaultVisibleRows = 5
 
-    internal let inspection = Inspection<Self>()
+    let inspection = Inspection<Self>()
 
     var body: some View {
         Group {

Coder Desktop/Coder Desktop/Views/LoginForm.swift

@@ -11,7 +11,7 @@ struct LoginForm<C: Client, S: Session>: View {
     @State private var loading: Bool = false
     @FocusState private var focusedField: LoginField?
 
-    internal let inspection = Inspection<Self>()
+    let inspection = Inspection<Self>()
 
     var body: some View {
         VStack {
@@ -56,7 +56,7 @@ struct LoginForm<C: Client, S: Session>: View {
             .onReceive(inspection.notice) { self.inspection.visit(self, $0) } // ViewInspector
     }
 
-    internal func submit() async {
+    func submit() async {
         loginError = nil
         guard sessionToken != "" else {
             loginError = .invalidToken
@@ -67,7 +67,7 @@ struct LoginForm<C: Client, S: Session>: View {
             return
         }
         loading = true
-        defer { loading = false}
+        defer { loading = false }
         let client = C(url: url, token: sessionToken)
         do {
             _ = try await client.user("me")
@@ -135,8 +135,8 @@ struct LoginForm<C: Client, S: Session>: View {
                 Button("Sign In") {
                     Task { await submit() }
                 }
-                    .buttonStyle(.borderedProminent)
-                    .keyboardShortcut(.defaultAction)
+                .buttonStyle(.borderedProminent)
+                .keyboardShortcut(.defaultAction)
             }.padding(.top, 5)
         }
     }

Coder Desktop/Coder Desktop/Views/Util.swift

@@ -1,7 +1,7 @@
 import Combine
 
 // This is required for inspecting stateful views
-internal final class Inspection<V> {
+final class Inspection<V> {
     let notice = PassthroughSubject<UInt, Never>()
     var callbacks = [UInt: (V) -> Void]()
 

Coder Desktop/Coder Desktop/Views/VPNMenu.swift

@@ -4,7 +4,7 @@ struct VPNMenu<VPN: VPNService, S: Session>: View {
     @EnvironmentObject var vpn: VPN
     @EnvironmentObject var session: S
 
-    internal let inspection = Inspection<Self>()
+    let inspection = Inspection<Self>()
 
     var body: some View {
         // Main stack

Coder Desktop/Coder Desktop/Views/VPNState.swift

@@ -3,7 +3,7 @@ import SwiftUI
 struct VPNState<VPN: VPNService>: View {
     @EnvironmentObject var vpn: VPN
 
-    internal let inspection = Inspection<Self>()
+    let inspection = Inspection<Self>()
 
     var body: some View {
         Group {

Coder Desktop/Coder DesktopTests/AgentsTests.swift

@@ -1,7 +1,7 @@
 @testable import Coder_Desktop
+import SwiftUI
 import Testing
 import ViewInspector
-import SwiftUI
 
 @Suite(.timeLimit(.minutes(1)))
 struct AgentsTests {
@@ -47,7 +47,7 @@ struct AgentsTests {
 
         let forEach = try view.inspect().find(ViewType.ForEach.self)
         #expect(forEach.count == Theme.defaultVisibleAgents)
-        #expect(throws: Never.self) { try view.inspect().find(link: "a1.coder")}
+        #expect(throws: Never.self) { try view.inspect().find(link: "a1.coder") }
     }
 
     @Test

Coder Desktop/Coder DesktopTests/LoginFormTests.swift

@@ -1,7 +1,7 @@
 @testable import Coder_Desktop
-import ViewInspector
-import Testing
 import SwiftUI
+import Testing
+import ViewInspector
 
 @Suite(.timeLimit(.minutes(1)))
 struct LoginTests {

Coder Desktop/Coder DesktopTests/Util.swift

@@ -67,10 +67,10 @@ struct MockClient: Client {
 }
 
 struct MockErrorClient: Client {
-    init(url: URL, token: String?) {}
-    func user(_ ident: String) async throws -> Coder_Desktop.User {
+    init(url _: URL, token _: String?) {}
+    func user(_: String) async throws -> Coder_Desktop.User {
         throw ClientError.badResponse
     }
 }
 
-extension Inspection: @retroactive InspectionEmissary { }
+extension Inspection: @retroactive InspectionEmissary {}

Coder Desktop/Coder DesktopTests/VPNMenuTests.swift

@@ -1,7 +1,7 @@
 @testable import Coder_Desktop
+import SwiftUI
 import Testing
 import ViewInspector
-import SwiftUI
 
 @Suite(.timeLimit(.minutes(1)))
 struct VPNMenuTests {

Coder Desktop/Coder DesktopTests/VPNStateTests.swift

@@ -1,7 +1,7 @@
 @testable import Coder_Desktop
-import ViewInspector
-import Testing
 import SwiftUI
+import Testing
+import ViewInspector
 
 @Suite(.timeLimit(.minutes(1)))
 struct VPNStateTests {

Coder Desktop/Coder DesktopUITests/Coder_DesktopUITests.swift

@@ -7,7 +7,8 @@ final class Coder_DesktopUITests: XCTestCase {
         // In UI tests it is usually best to stop immediately when a failure occurs.
         continueAfterFailure = false
 
-        // In UI tests it’s important to set the initial state - such as interface orientation - required for your tests before they run. The setUp method is a good place to do this.
+        // In UI tests it’s important to set the initial state - such as
+        // interface orientation - required for your tests before they run. The setUp method is a good place to do this.
     }
 
     override func tearDownWithError() throws {

Coder Desktop/Coder DesktopUITests/Coder_DesktopUITestsLaunchTests.swift

@@ -1,7 +1,7 @@
 import XCTest
 
 final class Coder_DesktopUITestsLaunchTests: XCTestCase {
-    override class var runsForEachTargetApplicationUIConfiguration: Bool {
+    override static var runsForEachTargetApplicationUIConfiguration: Bool {
         true
     }
 

Coder Desktop/VPN/PacketTunnelProvider.swift

@@ -1,28 +1,27 @@
 import NetworkExtension
 
 class PacketTunnelProvider: NEPacketTunnelProvider {
-
-    override func startTunnel(options: [String : NSObject]?, completionHandler: @escaping (Error?) -> Void) {
+    override func startTunnel(options _: [String: NSObject]?, completionHandler _: @escaping (Error?) -> Void) {
         // Add code here to start the process of connecting the tunnel.
     }
-    
-    override func stopTunnel(with reason: NEProviderStopReason, completionHandler: @escaping () -> Void) {
+
+    override func stopTunnel(with _: NEProviderStopReason, completionHandler: @escaping () -> Void) {
         // Add code here to start the process of stopping the tunnel.
         completionHandler()
     }
-    
+
     override func handleAppMessage(_ messageData: Data, completionHandler: ((Data?) -> Void)?) {
         // Add code here to handle the message.
         if let handler = completionHandler {
             handler(messageData)
         }
     }
-    
+
     override func sleep(completionHandler: @escaping () -> Void) {
         // Add code here to get ready to sleep.
         completionHandler()
     }
-    
+
     override func wake() {
         // Add code here to wake up.
     }