From b0cd6fd089a2971878b2d1d3464a8ddc97f7aa14 Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Wed, 24 Apr 2019 10:54:08 -0500 Subject: [PATCH 1/2] Disable beforeUnload when browser is in app mode --- packages/ide/src/client.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/ide/src/client.ts b/packages/ide/src/client.ts index 63f91bdeba7a..f7b32533c8c2 100644 --- a/packages/ide/src/client.ts +++ b/packages/ide/src/client.ts @@ -35,10 +35,14 @@ export abstract class IdeClient { let appWindow: Window | undefined; - window.addEventListener("beforeunload", (e) => { - e.preventDefault(); // FireFox - e.returnValue = ""; // Chrome - }); + if (!window.matchMedia("(display-mode: standalone)").matches) { + console.log("Not in app mode"); + window.addEventListener("beforeunload", (e) => { + e.preventDefault(); // FireFox + e.returnValue = ""; // Chrome + }); + } + window.addEventListener("message", (event) => { if (event.data === "app") { From d04521aaceac29d4a9276e6b731c57e4c1cb9bed Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Wed, 24 Apr 2019 10:59:19 -0500 Subject: [PATCH 2/2] Remove console log --- packages/ide/src/client.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/ide/src/client.ts b/packages/ide/src/client.ts index f7b32533c8c2..42e72e8c8469 100644 --- a/packages/ide/src/client.ts +++ b/packages/ide/src/client.ts @@ -36,7 +36,6 @@ export abstract class IdeClient { let appWindow: Window | undefined; if (!window.matchMedia("(display-mode: standalone)").matches) { - console.log("Not in app mode"); window.addEventListener("beforeunload", (e) => { e.preventDefault(); // FireFox e.returnValue = ""; // Chrome