From 21f5ef295187ed0ce3dcfc00069e34b37a19cf2a Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Mon, 22 Apr 2019 18:45:12 -0500 Subject: [PATCH 1/3] Let people know when telemetry is disabled, change url to https if secure connection --- packages/server/src/cli.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts index 9d91b6723ecb..fbfe8338b9d2 100644 --- a/packages/server/src/cli.ts +++ b/packages/server/src/cli.ts @@ -310,8 +310,12 @@ const bold = (text: string | number): string | number => { } else { logger.warn("Launched without authentication."); } + if (options.disableTelemetry) { + logger.info("Telemetry is disabled"); + } - const url = `http://localhost:${options.port}/`; + let schema = (options.noAuth || options.allowHttp) ? "http" : "https"; + const url = `${schema}://localhost:${options.port}/`; logger.info(" "); logger.info("Started (click the link below to open):"); logger.info(url); From c80cf4651b8beca8589aee69a9e1a08ba0fb3e67 Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Tue, 23 Apr 2019 10:18:52 -0500 Subject: [PATCH 2/3] Remove --no-auth as a http candidate --- packages/server/src/cli.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts index fbfe8338b9d2..ecd8e7342bd7 100644 --- a/packages/server/src/cli.ts +++ b/packages/server/src/cli.ts @@ -314,7 +314,7 @@ const bold = (text: string | number): string | number => { logger.info("Telemetry is disabled"); } - let schema = (options.noAuth || options.allowHttp) ? "http" : "https"; + let schema = options.allowHttp ? "http" : "https"; const url = `${schema}://localhost:${options.port}/`; logger.info(" "); logger.info("Started (click the link below to open):"); From b99259fbb49b226b4b43abc2e488ef1655d12dc9 Mon Sep 17 00:00:00 2001 From: John McCambridge Date: Tue, 23 Apr 2019 15:14:01 -0500 Subject: [PATCH 3/3] Rename variable, change let to const --- packages/server/src/cli.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts index ecd8e7342bd7..42ef342f81f9 100644 --- a/packages/server/src/cli.ts +++ b/packages/server/src/cli.ts @@ -314,8 +314,8 @@ const bold = (text: string | number): string | number => { logger.info("Telemetry is disabled"); } - let schema = options.allowHttp ? "http" : "https"; - const url = `${schema}://localhost:${options.port}/`; + const protocol = options.allowHttp ? "http" : "https"; + const url = `${protocol}://localhost:${options.port}/`; logger.info(" "); logger.info("Started (click the link below to open):"); logger.info(url);