From 4624eb7c0744ae2a0f2235b3991c65365df2d741 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Fri, 4 Mar 2022 16:13:33 -0700 Subject: [PATCH 1/3] feat: add new test for logLevels From 7fa998e0f125cddd81af2e393eed559ee40ac0df Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Fri, 4 Mar 2022 16:21:59 -0700 Subject: [PATCH 2/3] wip --- test/unit/node/cli.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/unit/node/cli.test.ts b/test/unit/node/cli.test.ts index ec3f5ab6279c..42c75c037d96 100644 --- a/test/unit/node/cli.test.ts +++ b/test/unit/node/cli.test.ts @@ -192,6 +192,8 @@ describe("parser", () => { }) expect(process.env.LOG_LEVEL).toEqual("trace") expect(logger.level).toEqual(Level.Trace) + + // TODO@jsjoeio - add the test here for error }) it("should ignore invalid log level env var", async () => { From 04b72393e42637ce59cd7ff7266e22271a22c35a Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 7 Mar 2022 14:54:03 -0700 Subject: [PATCH 3/3] feat: add test for valid log level env var --- test/unit/node/cli.test.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/unit/node/cli.test.ts b/test/unit/node/cli.test.ts index 42c75c037d96..47d02aece847 100644 --- a/test/unit/node/cli.test.ts +++ b/test/unit/node/cli.test.ts @@ -192,8 +192,15 @@ describe("parser", () => { }) expect(process.env.LOG_LEVEL).toEqual("trace") expect(logger.level).toEqual(Level.Trace) + }) - // TODO@jsjoeio - add the test here for error + it("should set valid log level env var", async () => { + process.env.LOG_LEVEL = "error" + const defaults = await setDefaults(parse([])) + expect(defaults).toEqual({ + ...defaults, + log: "error", + }) }) it("should ignore invalid log level env var", async () => {