From 811557fbb58c3dc12423edf7648c7cb33df825b2 Mon Sep 17 00:00:00 2001 From: Asher Date: Tue, 15 Jun 2021 10:40:23 -0500 Subject: [PATCH] Fix incorrect logout base Fixes #3608. --- CHANGELOG.md | 2 +- src/node/routes/logout.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bc4194d83df3..e04a563fd51d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,7 +43,7 @@ VS Code v0.00.0 ### Bug Fixes -- item +- Fix logout when using a base path (#3608) ### Documentation diff --git a/src/node/routes/logout.ts b/src/node/routes/logout.ts index e42789b48e23..d1a19dfef286 100644 --- a/src/node/routes/logout.ts +++ b/src/node/routes/logout.ts @@ -8,7 +8,7 @@ router.get("/", async (req, res) => { // Must use the *identical* properties used to set the cookie. res.clearCookie(Cookie.Key, { domain: getCookieDomain(req.headers.host || "", req.args["proxy-domain"]), - path: req.body.base || "/", + path: req.query.base || "/", sameSite: "lax", })