Separate process wrappers and pass arguments #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think having them combined and relying on if statements was getting confusing especially if we want to add additional messages with different payloads (which will soon be the case).
Fixes #2316.
Also move our memory default to the beginning of NODE_OPTIONS so it can be overidden. The version of the flag with dashes seems to be the more correct one now so use that instead of underscores. Related: #2113.
nhooyr
suggested changes
Nov 19, 2020
nhooyr
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #2316.
Previously we only deleted
PASSWORDin the child process but now it's deleted in the parent (which I think is good since that means it'll be hidden from the VS Code CLI spawn as well and anything else we might spawn from the parent in the future).But as a consequence the child no longer has access to
PASSWORDand can't use it when parsing the arguments. This PR fixes that by passing the arguments from the parent to the child.As a bonus this means we only have to do the parsing once, including if it gets restarted via a SIGUSR1.
Since it was getting a little convoluted with all the if statements I split out the child and parent process wrappers which I think makes it all a little more clear. Also was able to re-use
onMessagefrom the VS Code wrapper.