From 3bf310821bbf922314c770fe70c1f2e02f72b1e3 Mon Sep 17 00:00:00 2001 From: Anmol Sethi Date: Sun, 10 Mar 2019 12:06:25 -0400 Subject: [PATCH 1/2] Dockerfile: fix ENTRYPOINT must be provided in exec form for args from docker run to be passed correctly. See https://docs.docker.com/engine/reference/builder/#cmd --- Dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index dbe5613767ef..440cb0183ae1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -28,5 +28,4 @@ RUN apt-get install -y locales && \ # We unfortunately cannot use update-locale because docker will not use the env variables # configured in /etc/default/locale so we need to set it manually. ENV LANG=en_US.UTF-8 -ENTRYPOINT code-server -CMD ["."] +ENTRYPOINT ["code-server"] From 674242f84dcf511886dcbca856d97efb3c486b03 Mon Sep 17 00:00:00 2001 From: Anmol Sethi Date: Sun, 10 Mar 2019 12:58:52 -0400 Subject: [PATCH 2/2] build: fix reuse of vscode repository regression See #167 --- build/tasks.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/build/tasks.ts b/build/tasks.ts index d7cc6283b695..4c10b1fb4520 100644 --- a/build/tasks.ts +++ b/build/tasks.ts @@ -10,7 +10,7 @@ const libPath = path.join(__dirname, "../lib"); const vscodePath = path.join(libPath, "vscode"); const pkgsPath = path.join(__dirname, "../packages"); const defaultExtensionsPath = path.join(libPath, "VSCode-linux-x64/resources/app/extensions"); -const vscodeVersion = "1.32"; +const vscodeVersion = "1.32.0"; const buildServerBinary = register("build:server:binary", async (runner) => { await ensureInstalled(); @@ -220,11 +220,17 @@ const ensureCloned = register("vscode:clone", async (runner) => { } else { fse.mkdirpSync(libPath); runner.cwd = libPath; - const clone = await runner.execute("git", ["clone", "https://github.com/microsoft/vscode", "--branch", `release/${vscodeVersion}`, "--single-branch", "--depth=1"]); + const clone = await runner.execute("git", ["clone", "https://github.com/microsoft/vscode", "--branch", vscodeVersion, "--single-branch", "--depth=1"]); if (clone.exitCode !== 0) { throw new Error(`Failed to clone: ${clone.exitCode}`); } } + + runner.cwd = vscodePath; + const checkout = await runner.execute("git", ["checkout", vscodeVersion]); + if (checkout.exitCode !== 0) { + throw new Error(`Failed to checkout: ${checkout.stderr}`); + } }); const ensureClean = register("vscode:clean", async (runner) => {