Skip to content

iPad: Terminal input on chrome, iPad is hidden by keyboard #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
partyka1 opened this issue Sep 13, 2019 · 17 comments
Closed

iPad: Terminal input on chrome, iPad is hidden by keyboard #979

partyka1 opened this issue Sep 13, 2019 · 17 comments
Labels
browser-safari Safari related bug Something isn't working
Milestone

Comments

@partyka1
Copy link

partyka1 commented Sep 13, 2019

  • code-server version: code-server1.1156-vsc1.33.1-linux-x64
    OS Version: ubuntu 18.04 digitalocean + iPad pro 11" + folio keyboard

Description

On safari there is no problem with that. Look at the screenshot, actually there 4-5 lines more there, that are hidden by keyboard

Steps to Reproduce

  1. Open new terminal
  2. Start typing
  3. After few lines you can't see what you type because input is hidden by system keyboard
    image
@partyka1 partyka1 added the bug Something isn't working label Sep 13, 2019
@xlanor
Copy link

xlanor commented Sep 14, 2019

Can reproduce this, using an ipad pro 12.9" with a logitech slim folio pro.

Code-server deployed using code-server:2.1472-vsc1.38.1 docker image from dockerhub on Ubuntu 18.04 bionic.

However, I also observed this issue in v1 before I switched to v2.

Doesn't occur in safari (in safari it is pushed up nicely), but in safari, none of the top tabs work properly, they flicker on click.

@xlanor
Copy link

xlanor commented Sep 14, 2019

Here’s some screenshots to better demonstrate the layout in safari vs the layout currently getting in chrome

Safari:
IMG_0137

Chrome:
IMG_0136

@sr229
Copy link
Contributor

sr229 commented Sep 14, 2019

@partyka1 give v2 a try. v1 is already a deprecated version and we won't be issuing fixes in v1.

@xlanor
Copy link

xlanor commented Sep 14, 2019

@sr229 , this issue is still prevalent in image code-server:2.1472-vsc1.38.1 from dockerhub.

@sr229
Copy link
Contributor

sr229 commented Sep 14, 2019

Thanks for the report @xlanor. Will raise this to the team.

@partyka1
Copy link
Author

partyka1 commented Sep 23, 2019

@sr229 dev team should look at zeplin.io, im using their site on iPad and they have fixed elements on bottom of the screen that correctly react to keyboard ui situation that happens on iPad. Im sure vs code layout is another level of complexity, but if they are planning to address the issue this might help

@partyka1
Copy link
Author

I've found ohmazing workaround the problem, click View > Appearance > Move Side Bar Right then split the terminal view horizontally and rescale the bottom window so it offsets the top by the keyboard ui height @xlanor
5AD1C38C-E6D6-4D51-8B72-60C9FBA69A56

@xlanor
Copy link

xlanor commented Sep 23, 2019

Thanks! I guess thats an alternative, although it would be much preferable since I dont use my terminal that much - which is why the blocking affects me more.

@ttfan240
Copy link

If you disable "Shortcuts" in the iPad settings app, the keyboard screen itself will not appear.
Settings > General > Keyboard > Shortcuts
I didn't use the feature in the first place, so this is enough for me.
I use iPad in Japanese, so it may not be helpful.

@nhooyr nhooyr changed the title Terminal input on chrome, iPad is hidden by keyboard iPad: Terminal input on chrome, iPad is hidden by keyboard Jan 29, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Apr 17, 2020

@cmoog please test!

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 7, 2021

I’ve been using code-server on iPad as well. @ttfan240 issue resolved it for me.

@partyka1 will that solution work for you and can we close this?

@jsjoeio jsjoeio added this to the Backlog milestone Apr 29, 2021
@stale
Copy link

stale bot commented Oct 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Oct 26, 2021
@kmilov
Copy link

kmilov commented Oct 27, 2021

Indeed disabling Shortcuts and Predictive in Settings -> General -> Keyboard , on the iPad (pro M1) stops showing the bar in Code Server, with the disadvantage that the bar will be disabled everywhere.

is there an option to disabled it itself in the PWA Code Server ?

@stale stale bot removed the stale label Oct 27, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 28, 2021

@kmilov I don't think so :/ at least I'm not aware of any abilities to make those settings for specific PWAs.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Apr 27, 2022
@stale stale bot closed this as completed May 2, 2022
@YoungjuneKwon
Copy link

YoungjuneKwon commented Dec 12, 2023

Anybody knows the solution for this problem? I think this issue is still going, though it has been closed by stable bot. So I think the issue should be reopened.

@code-asher
Copy link
Member

Not sure about workarounds, but here is the upstream issue, feel free to give it a thumbs up: microsoft/vscode#149048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-safari Safari related bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants