-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add --base-path flag for use with absolute proxy #6770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @code-asher I've submitted a PR to resolve this case, could you have a look when you have a chance? Thanks |
I answered in the other issue, but as mentioned above
|
In other words, if you have an application on port 3000 and it requires absolute paths, and you have a reverse proxy serving code-server at Hope that helps! |
I think the long list of people that keep asking various questions on getting code-server to work under a base path should be a strong enough indicator that the docs are not thorough enough. |
Fair. I believe it is confusing because there are potentially two proxies: the one that hosts code-server, and code-server's built-in proxy, for viewing webapps you are working on. The base path flag is for code-server's built-in proxy. Nothing needs to be done to make code-server itself work behind another proxy, like Caddy or NGINX or so on. We are open to PRs that clarify the docs. I think I may be too close to the source code to understand how to word them in a way that makes sense to other folks. |
This is not for code-server itself (since it works relatively), it would just be prepended to
absproxy
requests for applications that need the full path.The text was updated successfully, but these errors were encountered: