Update Code to 1.88

[benz0li]

What is your suggestion?

Update Code to 1.88

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

[benz0li]

@code-asher VS Code 1.88.0 was released yesterday: https://code.visualstudio.com/updates/v1_88

I have tried to create a pull request... but my current setup with Node.js 18.20.x refuses to build:

yarn

yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Building fresh packages...
$ ./ci/dev/postinstall.sh
Installing dependencies for /home/benz0li/projects/code-server/test
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > [email protected]" has unmet peer dependency "typescript@>=3.8 <5.0".
[4/4] Building fresh packages...
Done in 80.51s.
Installing dependencies for /home/benz0li/projects/code-server/test/e2e/extensions/test-extension
yarn install v1.22.22
[1/5] Validating package.json...
warning [email protected]: The engine "vscode" appears to be invalid.
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Building fresh packages...
Done in 1.67s.
Installing dependencies for /home/benz0li/projects/code-server/lib/vscode
yarn install v1.22.22
$ node build/npm/preinstall.js
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "@microsoft/1ds-core-js > @microsoft/[email protected]" has unmet peer dependency "tslib@*".
warning " > [email protected]" has unmet peer dependency "@bazel/bazelisk@>=1.7.5".
warning " > [email protected]" has unmet peer dependency "@bazel/concatjs@>=5.3.0".
[4/4] Building fresh packages...
[11/20] ⢀ native-keymap
[2/20] ⢀ @vscode/policy-watcher
[7/20] ⢀ @vscode/windows-process-tree
[4/20] ⢀ @vscode/spdlog
error /home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments: 
Directory: /home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap
Output:
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info find Python using Python version 3.11.8 found at "/usr/local/bin/python3"

gyp info spawn /usr/local/bin/python3
gyp info spawn args [
gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/home/benz0li/.cache/node-gyp/18.20.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/home/benz0li/.cache/node-gyp/18.20.0',
gyp info spawn args '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/home/benz0li/.cache/node-gyp/18.20.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap/build'
  CXX(target) Release/obj.target/keymapping/src/string_conversion.o
  CXX(target) Release/obj.target/keymapping/src/keymapping.o
In file included from ../src/keymapping.cc:10:
../src/keymapping.cc: In function ‘napi_value__* vscode_keyboard::OnDidChangeKeyboardLayoutImpl(napi_env, napi_callback_info)’:
../src/keymapping.cc:100:50: error: invalid conversion from ‘void (*)(napi_env, void*, void*)’ {aka ‘void (*)(napi_env__*, void*, void*)’} to ‘node_api_nogc_finalize’ {aka ‘void (*)(const napi_env__*, void*, void*)’} [-fpermissive]
  100 |                                                  FinalizeThreadsafeFunction, NULL, NotifyJS,
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                  |
      |                                                  void (*)(napi_env, void*, void*) {aka void (*)(napi_env__*, void*, void*)}
../src/common.h:64:10: note: in definition of macro ‘NAPI_CALL_BASE’
   64 |     if ((the_call) != napi_ok) {                                         \
      |          ^~~~~~~~
../src/keymapping.cc:99:3: note: in expansion of macro ‘NAPI_CALL’
   99 |   NAPI_CALL(env, napi_create_threadsafe_function(env, func, NULL, resource_name, 0, 1, NULL,
      |   ^~~~~~~~~
In file included from /home/benz0li/.cache/node-gyp/18.20.0/include/node/node.h:79,
                 from ../src/keymapping.cc:6:
/home/benz0li/.cache/node-gyp/18.20.0/include/node/node_api.h:212:56: note:   initializing argument 8 of ‘napi_status napi_create_threadsafe_function(napi_env, napi_value, napi_value, napi_value, size_t, size_t, void*, node_api_nogc_finalize, void*, napi_threadsafe_function_call_js, napi_threadsafe_function__**)’
  212 |                                 node_api_nogc_finalize thread_finalize_cb,
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
make: *** [keymapping.target.mk:114: Release/obj.target/keymapping/src/keymapping.o] Error 1
make: Leaving directory '/home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
gyp ERR! System Linux 6.1.0-18-amd64
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/benz0li/projects/code-server/lib/vscode/node_modules/native-keymap




error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Cross reference: microsoft/node-native-keymap#58

[benz0li]

Back to Node.js 18.19.1. Building code-server 4.23.0-rc.1 with Code 1.88.0 right now.