Skip to content

[Bug]: global search and search by filename does not work in code-server installed from conda-forge #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
zegnog opened this issue Aug 23, 2023 · 3 comments
Closed
4 tasks done
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@zegnog
Copy link

zegnog commented Aug 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: chrome
  • Local OS: windows
  • Remote OS: linux
  • Remote Architecture: amd64
  • code-server --version: 4.16.1

Steps to Reproduce

  1. In a fresh conda environment, conda install -c conda-forge code-server
  2. open code-server
  3. open a folder with some text files
  4. try to search by filename using ctrl+P, or global search using ctrl+shift+F

Expected

Search works like in vscode or standalone code-server

Actual

for search by filename, only previously opened files are available.
for global search, only opened files are searched through.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

I am using conda forge to update and maintain my code-server up to the date. But I found global search and search by filename functions does not work in the version installed using conda-forge, it does work in standalone version though.
I am not using https, but it works locally so browser does not complain.

@zegnog zegnog added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Aug 23, 2023
@zegnog zegnog changed the title [Bug]: [Bug]: global search and search by filename does not work in code-server installed from conda-forge Aug 23, 2023
@code-asher
Copy link
Member

code-asher commented Aug 28, 2023

Ah I did not see this until I already commented on #1588. For visibility, I wrote there:

From what I recall this can happen if ripgrep is missing. I would
check the logs and see if the binary exists. I think it should be
lib/vscode/node_modules/@vscode/ripgrep/bin/rg

@zegnog
Copy link
Author

zegnog commented Aug 31, 2023

Thanks for the reply. I checked the path and the executable is here intact:
image

And I used code-server -vvv to produce the log as below:
temp.txt

A brief check does not give me any more info about why the search break. Except there are still other ways to get more logs?

@zegnog
Copy link
Author

zegnog commented Aug 31, 2023

Ugh, my bad, this issue is a duplicated with #5322 and conda-forge/code-server-feedstock#74 . I did not immediately connect those two together until you mentioned rg. The version released by conda forge now works normally after I manually replaced the installed rg with the on provided in standalone version.

Here close this issue in favor of #5322 .

@zegnog zegnog closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants