Skip to content

[Bug]: Terminal not showing up correct, and did not working at all after updating to 4.9.1 from 4.8.3 #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 4 tasks
Dionysos211 opened this issue Jan 21, 2023 · 21 comments
Labels
waiting-for-info Waiting for more information from submitter

Comments

@Dionysos211
Copy link

Dionysos211 commented Jan 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Safari
  • Local OS: MacOs
  • Remote OS: CentOS
  • Remote Architecture: amd64
  • code-server --version: 4.9.1

Steps to Reproduce

  1. update to 4.9.1
  2. with extensions
  3. just open Terminal Window -> bug
  4. clean reinstalled 4.8.3
  5. no extentions then with extentions
  6. just open Terminal Window -> NO bug
  7. clean reinstalled 4.9.1
  8. no extentions
  9. just open Terminal Window -> bug
  10. installed 4.8.3 OVER 4.9.1 (download extract)
  11. no extentions
  12. just open Terminal Window -> NO bug

Expected

Terminal should work as normal something went wrong from 4.8.3 to 4.9.1

Actual

actually I stay at 4.8.3 because 4.9.1 not works for me

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

if needed I can go on 4.9.1 and make screenshots
beause i have to check this marks before I can send it... I checked it, nut not true...

I cannot reproduce this in VS Code. Guess u mean local...
I CAN reproduce this in GitHub Codespaces. Terminal also bugged.

@Dionysos211 Dionysos211 added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jan 21, 2023
@Dionysos211
Copy link
Author

Bildschirmfoto 2023-01-21 um 03 10 56

here an image from GitHub Codespaces. where the same error is..
black
no prompt
no typing possible
if I hit enter something happens (blinking)

@Dionysos211
Copy link
Author

Also happens on other devices.. also error on GitHub Codespaces..

But on my resetted Server to 4.8.3 everything works fine..

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 23, 2023

What happens if you open 4.9.1 in an incognito window?

@jsjoeio jsjoeio added waiting-for-info Waiting for more information from submitter and removed bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jan 23, 2023
@Dionysos211
Copy link
Author

Dionysos211 commented Jan 23, 2023

still the same behavior also in different Browsers and on different devices and different OS...
... with 4.9.1 and Codespaces

@code-asher
Copy link
Member

If it happens in Codespaces we might benefit from reporting upstream.

@benz0li
Copy link
Contributor

benz0li commented Jan 28, 2023

@Dionysos211 Can you reproduce this on my reference deployment?

  1. Go to https://demo.jupyter.b-data.ch
  2. Log in with your GitHub account
  3. (Click "Start My Server")
  4. Select image R (jupyterlab/r/verse:latest)
  5. Open code-server
  6. Terminal: Create New Terminal

👉 If the server does not start the first time, simply give it another try.

@benz0li
Copy link
Contributor

benz0li commented Jan 28, 2023

@Dionysos211 What have you set "Terminal > Integrated: Gpu acceleration" (terminal.integrated.gpuAcceleration) to?

Maybe related to:

@Dionysos211
Copy link
Author

@Dionysos211 Can you reproduce this on my reference deployment?

  1. Go to https://demo.jupyter.b-data.ch
  2. Log in with your GitHub account
  3. (Click "Start My Server")
  4. Select image R (jupyterlab/r/verse:latest)
  5. Open code-server
  6. Terminal: Create New Terminal

👉 If the server does not start the first time, simply give it another try.

Hi,
I have now tried this once.
Unfortunately, the same error picture appears.
The terminal shows up with artifacts and you don't have the possibility to enter anything.

I have posted a screenshot for comparison:

  • Same system, same browser...
    Left: My server, where everything still works under version 4.8.3
    Middle: Your JupiterLab server, where the error occurs.
    Right: The GitHub Codespace server where the error also occurs.

Bildschirmfoto 2023-01-31 um 16 02 13

@Dionysos211
Copy link
Author

@Dionysos211 What have you set "Terminal > Integrated: Gpu acceleration" (terminal.integrated.gpuAcceleration) to?

Maybe related to:

Hi,
in all my test scenarios the setting of:
"Terminal > Integrated: Gpu acceleration".
was set to "Auto".

@Dionysos211
Copy link
Author

mhm sorry @code-asher but, what do you mean with: "reporting upstream"

@benz0li
Copy link
Contributor

benz0li commented Jan 31, 2023

Unfortunately, the same error picture appears.
The terminal shows up with artifacts and you don't have the possibility to enter anything.

When I open it in Safari, the problem is not showing up:

Screenshot_demo jupyter b-data ch

@Dionysos211
Copy link
Author

Dionysos211 commented Jan 31, 2023

hmm @benz0li, yes i see it...
unfortunately on my system it looks like shown in the screenshot.
And if I mark the lines in the terminal and copy them into a Editor I get the following:

[powerlevel10k] fetching gitstatusd .. [ok]
╭─    ~/projects ···························································································································· ✔  15:51:40 
╰─

but as you can see in the screenshot it is not visible...

@benz0li
Copy link
Contributor

benz0li commented Jan 31, 2023

  • Same system, same browser...

This problem is rather caused by your setup and/or browser than my reference deployment or GitHub Codespaces.

Unfortunately I can't help you any further. It may be a good idea to look for errors in the browser's console.
👉 Safari: Develop > Show Web Inspector; Firefox: Tools > Browser Tools > Web Developer Tools

@Dionysos211
Copy link
Author

  • Same system, same browser...

This problem is rather caused by your setup and/or browser than my reference deployment or GitHub Codespaces.

Unfortunately I can't help you any further. It may be a good idea to look for errors in the browser's console. 👉 Safari: Develop > Show Web Inspector; Firefox: Tools > Browser Tools > Web Developer Tools

ok @benz0li but why is everything running normally on my server with version 4.8.3 in the same browser with the same settings.
And when I updated my server to the latest version (I guess as the same on Codespace&Jupiterlab), I had the same problem on my server.

@benz0li
Copy link
Contributor

benz0li commented Jan 31, 2023

ok @benz0li but why is everything running normally on my server with version 4.8.3 in the same browser with the same settings.
And when I updated my server to the latest version (I guess as the same on Codespace&Jupiterlab), I had the same problem on my server.

I don't know.

Please check the browser's console output for errors.

@Dionysos211
Copy link
Author

Dionysos211 commented Jan 31, 2023

@benz0li here is the Console output, when I open a new Terminal Window

Bildschirmfoto 2023-01-31 um 16 42 54

edit: with filter off, there is also:

Bildschirmfoto 2023-01-31 um 16 50 15

@benz0li
Copy link
Contributor

benz0li commented Jan 31, 2023

@Dionysos211 Try disabling GPU acceleration.

Cross reference: microsoft/vscode#163448 (comment)

@Dionysos211
Copy link
Author

@benz0li ok wow that worked, change from auto to off... but why xD (canvas mode did not worked)

@benz0li
Copy link
Contributor

benz0li commented Jan 31, 2023

@Dionysos211 Gern geschehen!

@benz0li
Copy link
Contributor

benz0li commented Feb 1, 2023

@benz0li ok wow that worked, change from auto to off... but why xD (canvas mode did not worked)

@Dionysos211 If this resolves your problem, please close the issue.

Thank you.

@code-asher
Copy link
Member

Sorry, was out last week. Just for reference upstream is https://github.com/microsoft/vscode (thank you @benz0li for linking the issue upstream).

Generally bugs that can be reproduced in Codespaces can be reported there since it means code-server is not involved (basically we just wrap VS Code web which is what Codespaces is running).

Glad you got it sorted! Not sure why it worked in 4.8.3, hopefully the upstream issue gets it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info Waiting for more information from submitter
Projects
None yet
Development

No branches or pull requests

4 participants