Skip to content

release 4.9.1 #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Dec 13, 2022 · 9 comments · Fixed by #5893
Closed

release 4.9.1 #5874

jsjoeio opened this issue Dec 13, 2022 · 9 comments · Fixed by #5893
Assignees
@jsjoeio
Labels
enhancement Some improvement that isn't a feature
Milestone
4.9.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 13, 2022

No description provided.

@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Dec 13, 2022
@jsjoeio jsjoeio added this to the December 2022 milestone Dec 13, 2022
@jsjoeio jsjoeio self-assigned this Dec 13, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2022

Tested the macOS release in Incognito in Brave and looks good. Terminal is working.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2022 •
edited
Loading

Now I need to figure out why this error is happening on x86-64 Linux build: https://github.com/coder/code-server/actions/runs/3680549350/jobs/6226283270#step:16:18

cannot add "release-
standalone/node_modules/http-proxy-
agent/dist/index.d.ts" because "release-
standalone/node_modules/gtoken/build/src/index.d.ts" is 
already present at the same destination 
(/usr/lib/code-server/index.d.ts): content collision

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2022

I'm going to try re-running the job and see if it was a silly fluke.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2022

A different error this time:

cannot add "release-standalone/node_modules/@mapbox/node-pre-
gyp/LICENSE" because "release-
standalone/lib/vscode/node_modules/graceful-
fs/LICENSE" is already present at the same 
destination (/usr/lib/code-server/LICENSE): content collision

Hmm...I'm going to check GitHub Discussions. I think I saw someone post something about an nfpm error.

@jsjoeio jsjoeio mentioned this issue Dec 13, 2022
Merged
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 13, 2022

That seems to have done it! https://github.com/coder/code-server/actions/runs/3688259509

Next step is to cut a release candidate so the community can test before we do a full release.

@balajib-b
Copy link

@jsjoeio is this 1.74 or 1.73. The release information shows 1.73.1

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2022

1.73.1

We still need to upgrade to 1.74

@mehulmpt

This comment was marked as off-topic.

Sign in to view
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 14, 2022

Thank you @mehulmpt!

@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
@jsjoeio jsjoeio mentioned this issue Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
4.9.1
Development

Successfully merging a pull request may close this issue.

release: v4.9.1 coder/code-server
3 participants
@jsjoeio @mehulmpt @balajib-b