Skip to content

[Bug]: Invalid version in about window after 4.9.0 upgrade #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
pavelxdd opened this issue Dec 6, 2022 · 2 comments
Closed
4 tasks done

[Bug]: Invalid version in about window after 4.9.0 upgrade #5842

pavelxdd opened this issue Dec 6, 2022 · 2 comments
Assignees
@jsjoeio
Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Milestone
4.9.1

Comments

@pavelxdd
Copy link

pavelxdd commented Dec 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Arch Linux
  • Remote OS: Debian sid
  • Remote Architecture: amd64
  • code-server --version: 4.9.0 0502dfa with Code 1.73.1

Steps to Reproduce

  1. Open code-server
  2. Navigate to Menu->Help->About

Expected

Expected to see code-server: v4.9.0 in about dialog.
Expected to no see the blue icon in status bar suggesting to download code-server.

Actual

There a code-server: v$VERSION

About

Also there's a blue icon in status bar suggesting to download code-server, despite having launched with --disable-update-check

Status

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@pavelxdd pavelxdd added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Dec 6, 2022
@jsjoeio jsjoeio self-assigned this Dec 7, 2022
@jsjoeio jsjoeio removed the triage This issue needs to be triaged by a maintainer label Dec 7, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 7, 2022

I've upgraded to 4.9.0 via homebrew and have the same issue.

image

I'll look into this. Thanks for reporting!

@jsjoeio jsjoeio added this to the December 2022 milestone Dec 7, 2022
@jsjoeio jsjoeio added the high-priority This issue needs to be resolved ASAP label Dec 7, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 7, 2022

Fixed via #5845

@jsjoeio jsjoeio closed this as completed Dec 7, 2022
@jsjoeio jsjoeio mentioned this issue Dec 12, 2022
Closed
4 tasks
@jsjoeio jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working high-priority This issue needs to be resolved ASAP
Projects
None yet
Milestone
4.9.1
Development

No branches or pull requests
2 participants
@jsjoeio @pavelxdd