Skip to content

[Bug]: automatic hyperlinking broken in 4.8.0? #5716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
drmrbrewer opened this issue Oct 27, 2022 · 4 comments
Closed
4 tasks done

[Bug]: automatic hyperlinking broken in 4.8.0? #5716

drmrbrewer opened this issue Oct 27, 2022 · 4 comments
Labels
waiting-for-info Waiting for more information from submitter
Milestone

Comments

@drmrbrewer
Copy link

drmrbrewer commented Oct 27, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Windows
  • Remote OS: Ubuntu 22.04
  • Remote Architecture: x64
  • code-server --version: 1.72.1 (that's the version of vscode I think? code-server version is 4.8.0... see screenshot below)

image

Steps to Reproduce

  1. open code-server
  2. open code file including URL in the comments
  3. ctrl-click on the automatically-hyperlinked URL

Expected

Should open the linked page in a new page of the browser.

Actual

Nothing... except "Activating extensions..." indication in status bar at bottom:

image

This indication just disappears after a short time, but nothing else happens. Nothing in the browser console log either.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

This was working fine before... think it broke with the update to v4.8.0?

It is also broken (but was working before) for hyperlinks from URLs in the terminal window.

@drmrbrewer drmrbrewer added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Oct 27, 2022
@drmrbrewer drmrbrewer changed the title [Bug]: [Bug]: automatic hyperlinking broken in 4.8.0? Oct 27, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 27, 2022

Can you try 4.8.1's release candidate? I'm guessing this is the same CSP error we have in 4.8.0

@jsjoeio jsjoeio added waiting-for-info Waiting for more information from submitter and removed bug Something isn't working triage This issue needs to be triaged by a maintainer labels Oct 27, 2022
@drmrbrewer
Copy link
Author

drmrbrewer commented Oct 27, 2022

So to do that, and based on this issue, I use the normal install script but add --edge? Like so...

curl -fsSL https://code-server.dev/install.sh | sh -s -- --edge

@drmrbrewer
Copy link
Author

I answered this myself by trying it :)

Yes, installing as per my previous post has indeed installed the release candidate version:

image

And yes, the hyperlinking issue I reported at the top is fixed by the release candidate!

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 27, 2022

LOL hey at least you're proactive! Thank you for confirming! I'll close for now and add to the 4.8.1 milestone.

@jsjoeio jsjoeio closed this as completed Oct 27, 2022
@jsjoeio jsjoeio added this to the 4.8.1 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info Waiting for more information from submitter
Projects
None yet
Development

No branches or pull requests

2 participants