Skip to content

[Feat]: Add container lifecycle hook to helm chart #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
inerplat opened this issue Jul 26, 2022 · 3 comments
Closed

[Feat]: Add container lifecycle hook to helm chart #5382

inerplat opened this issue Jul 26, 2022 · 3 comments
Labels
enhancement Some improvement that isn't a feature
Milestone
v4.5.2

Comments

@inerplat
Copy link

inerplat commented Jul 26, 2022 •
edited
Loading

What is your suggestion?

Add container lifecycle hook to helm chart of code-server deployment.

Why do you want this feature?

When the code-server is restarted in kubernetes, all data in the area where the persistent volume is not mounted is lost.

How about adding a lifecycle hook like postStart for small configuration or script codes to manage without PV?

Are there any workarounds to get this functionality today?

Of course, I personally fork the helm chart of this project and use it.

Edit the chart as below:
https://github.com/inerplat/code-server/blob/main/ci/helm-chart/templates/deployment.yaml#L65-L75

It can inject settings via values.yaml:
https://github.com/inerplat/code-server/blob/main/ci/helm-chart/values.yaml#L130-L137

Are you interested in submitting a PR for this?

Yes
@inerplat inerplat added the enhancement Some improvement that isn't a feature label Jul 26, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 1, 2022

cc @bpmct any thoughts on this?

@jsjoeio jsjoeio added this to the Backlog Candidates milestone Aug 1, 2022
@bpmct
Copy link
Member

bpmct commented Aug 1, 2022

This seems reasonable to accept upstream. I'm happy to test it!

@jsjoeio jsjoeio modified the milestones: Backlog Candidates, On Deck Aug 1, 2022
@inerplat inerplat mentioned this issue Aug 2, 2022
Merged
@jsjoeio jsjoeio modified the milestones: On Deck, August 2022 Aug 3, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 9, 2022

Fixed via #5397

@jsjoeio jsjoeio closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
v4.5.2
Development

No branches or pull requests
3 participants
@jsjoeio @inerplat @bpmct