Skip to content

[Chore]: Investigate integration test flakes #5369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Jul 21, 2022 · 0 comments · Fixed by #5434
Closed

[Chore]: Investigate integration test flakes #5369

jsjoeio opened this issue Jul 21, 2022 · 0 comments · Fixed by #5434
Assignees
@jsjoeio
Labels
enhancement Some improvement that isn't a feature
Milestone
v4.5.2

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jul 21, 2022

Description

For some reason, the installExtesion test has been flaking out and we're not sure why:
https://github.com/coder/code-server/runs/7458796120?check_suite_focus=true#step:9:13

Solution

Replace it with another test like --help which fails if used on the wrong platform

For example, running --help with the Linux release on macOS results in this error:
image
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Jul 21, 2022
@jsjoeio jsjoeio added this to the July 2022 milestone Jul 21, 2022
@jsjoeio jsjoeio self-assigned this Jul 21, 2022
@jsjoeio jsjoeio mentioned this issue Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
v4.5.2
Development

Successfully merging a pull request may close this issue.

feat: add --help integration test coder/code-server
1 participant
@jsjoeio