Skip to content

[Chore]: refactor test dependencies #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Jun 23, 2022 · 0 comments
Closed

[Chore]: refactor test dependencies #5291

jsjoeio opened this issue Jun 23, 2022 · 0 comments
Assignees
@jsjoeio
Labels
chore Related to maintenance or clean up testing Anything related to testing
Milestone
On Deck - High Pr...

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 23, 2022

Pointed out by @code-asher, we should be separating our dependencies correctly. Right now the yarn test:integration relies on both dependencies at the root and in /test.

We need to move any test dependencies to /test/package.json (i.e. jest and typescript).

More discussion: #5275 (comment)
@jsjoeio jsjoeio added testing Anything related to testing chore Related to maintenance or clean up labels Jun 23, 2022
@jsjoeio jsjoeio added this to the On Deck - High Priority milestone Jun 23, 2022
@jsjoeio jsjoeio self-assigned this Jun 23, 2022
@jsjoeio jsjoeio mentioned this issue Jun 23, 2022
Merged
@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
chore Related to maintenance or clean up testing Anything related to testing
Projects
None yet
Milestone
On Deck - High Priority
Development

No branches or pull requests
2 participants
@jsjoeio @code-asher