Skip to content

[Bug]: ripgrep not getting properly carried around when the remote system is FreeBSD #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
rowheel opened this issue May 22, 2022 · 4 comments
Closed
3 tasks done

[Bug]: ripgrep not getting properly carried around when the remote system is FreeBSD #5216

rowheel opened this issue May 22, 2022 · 4 comments
Assignees
@jsjoeio
Labels
bug Something isn't working upstream Needs to be fixed upstream
Milestone
On Deck - High Pr...

Comments

@rowheel
Copy link

rowheel commented May 22, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Google Chrome
  • Local OS: Arch Linux
  • Remote OS: FreeBSD 13.1-RELEASE
  • Remote Architecture: amd64
  • code-server --version: 4.4.0 b088ec7 with Code 1.66.2

Steps to Reproduce

  1. Open code-server
  2. Press Ctrl-Shift-F to type in any search keyword
  3. And it gets an error like this

image

Expected

The ripgrep executable is expected to be present at this place.

Actual

But actually it's not, and users have to manually symlink the system-wide installed instance of ripgrep to that place persumably like this:

$ ln -sf $(which rg) $(yarn global dir)/node_modules/code-server/lib/vscode/node_modules/@vscode/ripgrep/bin

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response
@rowheel rowheel added bug Something isn't working triage This issue needs to be triaged by a maintainer labels May 22, 2022
@rowheel rowheel changed the title [Bug]: ripgrep not getting proper carried around when the OS is FreeBSD [Bug]: ripgrep not getting properly carried around when the remote system is FreeBSD May 22, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented May 23, 2022

Hmm..I've seen this before but can't recall how we fixed it. We'll need to investigate. Thank you!

@jsjoeio jsjoeio added needs-investigation This issue needs to be further investigated and removed triage This issue needs to be triaged by a maintainer labels May 23, 2022
@jsjoeio jsjoeio added this to the On Deck - High Priority milestone May 23, 2022
@rowheel
Copy link
Author

rowheel commented May 24, 2022

Thanks for looking into it, @jsjoeio .

Could you please also add this workaround to FreeBSD guide or troubleshooting?

@jsjoeio
Copy link
Contributor

jsjoeio commented May 24, 2022

@das-rob3rt certainly!

@jsjoeio jsjoeio self-assigned this May 24, 2022
@bolliger32 bolliger32 mentioned this issue Jul 4, 2022
Closed
4 tasks
@code-asher
Copy link
Member

Closing as an upstream issue, as I believe the ripgrep module would need to add support for FreeBSD?

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@code-asher code-asher added upstream Needs to be fixed upstream and removed needs-investigation This issue needs to be further investigated labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working upstream Needs to be fixed upstream
Projects
None yet
Milestone
On Deck - High Priority
Development

No branches or pull requests
3 participants
@jsjoeio @rowheel @code-asher