Skip to content

[Bug]: Cannot find module 'keytar' #5018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
benz0li opened this issue Mar 23, 2022 · 2 comments
Closed
3 tasks done

[Bug]: Cannot find module 'keytar' #5018

benz0li opened this issue Mar 23, 2022 · 2 comments
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@benz0li
Copy link
Contributor

benz0li commented Mar 23, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: Firefox 98.0.1 (64-bit)
  • Local OS: macOS 12.3 (Monterey)
  • Remote OS: Debian bullseye
  • Remote Architecture: aarch64
  • code-server --version: 4.2.0 693b1fa with Code 1.64.2

Steps to Reproduce

  1. open code-server

Expected

Find module 'keytar'.

Actual

Cannot find module 'keytar'.

Logs

[...]
[hh:mm:ss] Switching to using in-memory credential store instead because Keytar failed to load: Cannot find module 'keytar'
[...]

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

No response

@benz0li benz0li added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Mar 23, 2022
@benz0li
Copy link
Contributor Author

benz0li commented Mar 23, 2022

Is module keytar intentionally not installed.

If so, you may close the issue.

@benz0li
Copy link
Contributor Author

benz0li commented Mar 23, 2022

# Use the package.json for the web/remote server. It does not have the right
# version though so pull that from the main package.json. Also remove keytar
# since the web does not rely on it and that removes the dependency on
# libsecret.
jq --slurp '.[0] * {version: .[1].version} | del(.dependencies.keytar)' \
"$VSCODE_SRC_PATH/remote/package.json" \
"$VSCODE_SRC_PATH/package.json" > "$VSCODE_OUT_PATH/package.json"

So this is on purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant