Skip to content

[Chore]: fix npm workflow #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Mar 4, 2022 · 3 comments · Fixed by #4995
Closed

[Chore]: fix npm workflow #4949

jsjoeio opened this issue Mar 4, 2022 · 3 comments · Fixed by #4995
Assignees
Labels
chore Related to maintenance or clean up ci Issues related to ci
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 4, 2022

I think the download-artifact action is trying to download from that workflow rather than the workflow that ran on the version branch maybe?

I suppose this could be why Anmol used a manual script for downloading instead; I tried looking for an option to download from a specific branch but am not seeing it (edited)

Really unfortunate though...maybe we can think of a new architecture where we can use download-artifact

See here: https://github.com/coder/code-server/runs/5424884882?check_suite_focus=true

@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Mar 4, 2022
@jsjoeio jsjoeio added this to the March 2022 milestone Mar 4, 2022
@jsjoeio jsjoeio self-assigned this Mar 8, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 14, 2022

Related: #2817

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 15, 2022

@code-asher what do you think about using something like semantic-release to fix the npm workflow but also streamline the release process?

Potential flow:

image

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Mar 15, 2022

@code-asher and I talked about this. Makes sense to keep this and #2817 separate. The fix for this issue is using something like https://github.com/dawidd6/action-download-artifact and downloading the artifact from the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
1 participant