Skip to content

[Feat]: publish dev builds to @coder/code-server-pr #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsjoeio opened this issue Feb 28, 2022 · 0 comments · Fixed by #4972
Closed

[Feat]: publish dev builds to @coder/code-server-pr #4924

jsjoeio opened this issue Feb 28, 2022 · 0 comments · Fixed by #4972
Assignees
Labels
ci Issues related to ci enhancement Some improvement that isn't a feature
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 28, 2022

What is your suggestion?

Currently, we publish dev builds to npm under the same code-server name and tag it with a PR like code-server@4569. Instead, we should publish dev builds to a separate npm namespace: @coder/code-server-pr.

How to do this?

We'll need to modify this logic

https://github.com/coder/code-server/blob/main/ci/steps/publish-npm.sh#L111-L118

Basically, we need to add a line there that replaces "name": "code-server" with "name": "@coder/code-server-pr". That should be it. We shouldn't have to add a new NPM_TOKEN since they're not scoped to packages.

Why do you want this feature?

As @jawnsy brought up, this is cluttering the tags under the code-server package and makes it look ugly but also makes it hard for users to see actual versions.

image

Are there any workarounds to get this functionality today?

The current workaround is to just leave it as is.

Are you interested in submitting a PR for this?

Yes! But also open to mentor others who might be interested in doing this :)

@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature ci Issues related to ci labels Feb 28, 2022
@jsjoeio jsjoeio added this to the March 2022 milestone Feb 28, 2022
@jsjoeio jsjoeio self-assigned this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci enhancement Some improvement that isn't a feature
Projects
None yet
1 participant