Skip to content

Broken link on code-server install docs #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NyleCohen opened this issue Nov 23, 2021 · 6 comments · Fixed by #4627
Closed

Broken link on code-server install docs #4545

NyleCohen opened this issue Nov 23, 2021 · 6 comments · Fixed by #4627
Assignees
Labels
docs Documentation related
Milestone

Comments

@NyleCohen
Copy link

On the code-server docs website, the "install script" hyperlink goes to this 404. This link should either be fixed or be changed to the install.sh script on github.

@NyleCohen NyleCohen added the docs Documentation related label Nov 23, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 23, 2021

Whoops! Looks like we need to fix that. Thanks for reporting!

@jsjoeio jsjoeio added this to the 4.0.1 milestone Nov 23, 2021
@im-coder-lg
Copy link
Contributor

I hit the 404. Maybe I have to check this. I will post DevTools Console logs here soon.

@im-coder-lg
Copy link
Contributor

im-coder-lg commented Nov 25, 2021

Over here:

Failed to load resource: net::ERR_FILE_NOT_FOUND
dc.ads.linkedin.com/:1 Failed to load resource: net::ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep
install#installsh:1 Access to fetch at 'https://s-install.avcdn.net/aos/assets/prod/translations/Locale-en-US.json' from origin 'https://coder.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
s-install.avcdn.net/aos/assets/prod/translations/Locale-en-US.json:1 Failed to load resource: net::ERR_FAILED
VM196:1 _recent_lead_source cookie set: "Inbound Link"
/_next/data/yfJ74FBiREKmUMA0T1qLO/docs/code-server/latest/install.sh.json:1 Failed to load resource: the server responded with a status of 404 ()

We hit a CORS problem(seems unrelated but thought you must know). I experienced this but don't know where, when and how.
Edit: Look at this: /_next/data/yfJ74FBiREKmUMA0T1qLO/docs/code-server/latest/install.sh.json:1 Failed to load resource: the server responded with a status of 404 ()
Looks like we found the problem. @jsjoeio what do you think?
Next, using the point-on-the-component trick, I found this:
image
Can't we add https://code-server.dev/install.sh which shows the raw code? I think that file moved directories so this is happening.

@im-coder-lg
Copy link
Contributor

We should do what @NyleCohen said. I think that would work better but also, we need to make the redirect open in a new tab.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 29, 2021

Nice debugging @im-coder-lg!

Yes, I agree. We'll need to fix this like @NyleCohen suggested

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.0.0 Dec 13, 2021
@jsjoeio jsjoeio self-assigned this Dec 14, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

I'm installing it with npm on a raspberry pi and I'm getting the same problem, a 404 error (in addition to a bunch of warnings lol) after making a request to what I believe is https://code-server.dev/install.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants